Initial structure and parallelization of parser #66

pkukielka · 2018-05-17T15:13:17Z

Results from perf_tester:

Parser phase comparison:

19:30:25 after 0 best 10%, phase parser
19:30:25                  Run Name	Cycle	samples	           Wall time (ms)	       All Wall time (ms)	                  CPU(ms)	           Idle time (ms)	           Allocated(MBs)
19:30:25                  baseline	   1	   5	 1,075.80 [-0.45% +0.39%]	 1,075.80 [-0.45% +0.39%]	 1,075.80 [-0.45% +0.39%]	       0.00 [ NaN%  NaN%]	   450.69 [-4.45% +2.69%]
19:30:25                  baseline	   2	   5	   990.40 [-0.55% +0.67%]	   990.40 [-0.55% +0.67%]	   990.20 [-0.53% +0.59%]	       0.00 [ NaN%  NaN%]	   451.92 [-4.95% +3.39%]

18:43:04 after 0 best 10%, phase parser
18:43:04                  Run Name	Cycle	samples	           Wall time (ms)	       All Wall time (ms)	                  CPU(ms)	           Idle time (ms)	           Allocated(MBs)
18:43:04                    parser	   1	   5	   308.00 [-1.62% +0.97%]	   308.00 [-1.62% +0.97%]	    14.40 [-2.78% +4.17%]	       0.00 [ NaN%  NaN%]	     2.97 [-0.04% +0.03%]
18:43:04                    parser	   2	   5	   280.60 [-1.64% +0.86%]	   280.60 [-1.64% +0.86%]	    14.20 [-8.45% +5.63%]	       0.00 [ NaN%  NaN%]	     2.96 [-0.02% +0.01%]

Total comparison:

19:30:25 after 0 best 10%
19:30:25                  Run Name	Cycle	samples	           Wall time (ms)	       All Wall time (ms)	                  CPU(ms)	           Idle time (ms)	           Allocated(MBs)
19:30:25                  baseline	   1	   5	21,656.80 [-5.55% +1.83%]	21,656.80 [-5.55% +1.83%]	21,471.40 [-5.28% +2.00%]	       0.00 [ NaN%  NaN%]	 3,804.04 [-0.83% +0.50%]
19:30:25                  baseline	   2	   5	20,870.00 [-0.95% +1.10%]	20,870.00 [-0.95% +1.10%]	20,773.40 [-0.91% +1.13%]	       0.00 [ NaN%  NaN%]	 3,808.93 [-0.95% +0.52%]

18:43:04 after 0 best 10%
18:43:04                  Run Name	Cycle	samples	           Wall time (ms)	       All Wall time (ms)	                  CPU(ms)	           Idle time (ms)	           Allocated(MBs)
18:43:04                    parser	   1	   5	22,126.00 [-2.44% +1.67%]	22,126.00 [-2.44% +1.67%]	21,640.20 [-2.21% +1.76%]	       0.00 [ NaN%  NaN%]	 3,421.77 [-0.29% +0.18%]
18:43:04                    parser	   2	   5	20,689.60 [-0.72% +0.59%]	20,689.60 [-0.72% +0.59%]	20,267.60 [-0.61% +0.72%]	       0.00 [ NaN%  NaN%]	 3,356.09 [-0.01% +0.01%]

This is with rangepos enabled.

mkeskells · 2018-05-17T19:48:50Z

src/compiler/scala/tools/nsc/Global.scala

@@ -953,7 +996,9 @@ class Global(var currentSettings: Settings, reporter0: Reporter)
 * of what file was being compiled when it broke. Since I really
 * really want to know, this hack.
 */
- protected var lastSeenSourceFile: SourceFile = NoSourceFile
+ protected var _lastSeenSourceFile: ThreadIdentityAwareThreadLocal[SourceFile] = ThreadIdentityAwareThreadLocal(NoSourceFile)


private[this] final val ?

mkeskells · 2018-05-17T19:57:14Z

src/compiler/scala/tools/nsc/Global.scala

@@ -953,7 +996,9 @@ class Global(var currentSettings: Settings, reporter0: Reporter)
 * of what file was being compiled when it broke. Since I really
 * really want to know, this hack.
 */
- protected var lastSeenSourceFile: SourceFile = NoSourceFile
+ protected var _lastSeenSourceFile: ThreadIdentityAwareThreadLocal[SourceFile] = ThreadIdentityAwareThreadLocal(NoSourceFile)
+ @inline protected def lastSeenSourceFile: SourceFile = _lastSeenSourceFile.get


it will need to be final to @inline

Should be final anyway I think

The pattern is that we replace
<prot> var <name>: <type>
with

private[this] final _<name> = new ThreadIdentityAwareThreadLocal[<type>](...) <prot> final def <name> : <type> = _<name>.get <prot> final def <name>_=(newValue: <type>) = _<name>.set(newValue)

mkeskells · 2018-05-17T20:00:55Z

src/compiler/scala/tools/nsc/Global.scala

- private var phasec: Int  = 0 // phases completed
- private var unitc: Int = 0 // units completed this phase
+ private var phasec: Int = 0  // phases completed
+ private final val unitc: AtomicInteger = new AtomicInteger(0) // units completed this phase


I think that can be a Parallel.Counter
and AtomicInteger, with get, increment (or maybe +=) and reset
we can also add assertions on the access in the same way

mkeskells · 2018-05-17T20:30:17Z

src/compiler/scala/tools/nsc/Global.scala

+ // If we are on main thread it means there are no worker threads at all.
+ // That in turn means we were already using main reporter all the time, so there is nothing more to do.
+ // Otherwise we have to forward messages from worker thread reporter to main one.
+ reporter match {


this doesn't work - we need to report in order - that was why I had the local data for this

we should move this to a relay method on the StoreReporter I think, or a new RelayingReporter or some such

mkeskells · 2018-05-17T20:40:06Z

src/compiler/scala/tools/nsc/util/ThreadIdentityAwareThreadLocal.scala

+ def apply[T](valueOnWorker: => T, valueOnMain: => T) = new ThreadIdentityAwareThreadLocal[T](valueOnWorker, valueOnMain)
+}
+
+// `ThreadIdentityAwareThreadLocal` allows us to have different (sub)type of values on main and worker threads.


I think that we have 3 modes
admin - running setup and cleardown on the main thread
parallel-worker
single-worker

It may be easier to have this single worker on a seperate single thread to keep it simple

The ThreadFactory used for the async executor can provide a subclass of Thread - ParallelWorkerThread - it makes this switch easier

mkeskells · 2018-05-17T20:41:06Z

src/compiler/scala/tools/nsc/util/ThreadIdentityAwareThreadLocal.scala

@@ -0,0 +1,39 @@
+package scala.tools.nsc.util
+
+object ThreadIdentityAwareThreadLocal {


Maybe a object Parallel, with all of the Parallel compilation extras in one place?

mkeskells · 2018-05-17T20:42:17Z

src/reflect/scala/reflect/api/Trees.scala

@@ -2535,7 +2538,9 @@ trait Trees { self: Universe =>
 val treeCopy: TreeCopier = newLazyTreeCopier

 /** The current owner symbol. */
- protected[scala] var currentOwner: Symbol = rootMirror.RootClass
+ protected[scala] def currentOwner: Symbol = _currentOwner.get


make these final pls

mkeskells · 2018-05-17T20:43:09Z

src/reflect/scala/reflect/internal/Names.scala

@@ -27,7 +27,7 @@ trait Names extends api.Names {
 // detect performance regressions.
 //
 // Discussion: https://groups.google.com/forum/#!search/biased$20scala-internals/scala-internals/0cYB7SkJ-nM/47MLhsgw8jwJ
- protected def synchronizeNames: Boolean = false
+ protected def synchronizeNames: Boolean = true


do we need this?

Yes we do.
Umad reports violation in this class:

[WARN] Method accessed from multiple threads (main, scalac-parser-worker-1): scala.reflect.internal.SymbolTable.scala$reflect$internal$Names$$nc_$eq(int) scala.reflect.internal.SymbolTable.scala$reflect$internal$Names$$nc_$eq(SymbolTable.scala) scala.reflect.internal.Names.enterChars(Names.scala:78) scala.reflect.internal.Names.body$1(Names.scala:116) scala.reflect.internal.Names.newTermName(Names.scala:127) scala.reflect.internal.Names.newTermName$(Names.scala:96) scala.reflect.internal.SymbolTable.newTermName(SymbolTable.scala:18) scala.reflect.internal.Names.newTermName(Names.scala:83) scala.reflect.internal.Names.newTermName$(Names.scala:82) scala.reflect.internal.SymbolTable.newTermName(SymbolTable.scala:18) scala.reflect.internal.Names.newTermName(Names.scala:85)

What synchronizeNames do is enabling synchronization on the newTermName.
It looks like something designed exactly for our use case so I happily used it.
There were some concerns regarding enabling it globally though (mostly performance ones): https://groups.google.com/forum/#!search/biased$20scala-internals/scala-internals/0cYB7SkJ-nM/47MLhsgw8jwJ

mkeskells · 2018-05-17T20:48:20Z

src/reflect/scala/reflect/internal/Reporting.scala

@@ -79,6 +79,8 @@ import util.Position
 abstract class Reporter {
 protected def info0(pos: Position, msg: String, severity: Severity, force: Boolean): Unit

+ def infoRaw(pos: Position, msg: String, severity: Severity, force: Boolean): Unit = info0(pos, msg, severity, force)


is this just for relay?

mkeskells · 2018-05-17T21:34:53Z

src/reflect/scala/reflect/internal/Symbols.scala

@@ -3116,8 +3116,10 @@ trait Symbols extends api.Symbols { self: SymbolTable =>
 * type arguments.
 */
 override def tpe_* : Type = {
- maybeUpdateTypeCache()
- tpeCache
+ this.synchronized {


is this safe - can we cross symbols with this lock?
I dont see how, but there are checks for cycles, so if there are it implies crossing

I think we need to discuss this.
Stack trace for the reference:

[WARN] Method accessed from multiple threads (scalac-parser-worker-3, scalac-parser-worker-2): scala.reflect.internal.Symbols$TypeSymbol.tpeCache_$eq(scala.reflect.internal.Types$Type) scala.reflect.internal.Symbols$TypeSymbol.tpeCache_$eq(Symbols.scala) scala.reflect.internal.Symbols$TypeSymbol.updateTypeCache(Symbols.scala:3155) scala.reflect.internal.Symbols$TypeSymbol.maybeUpdateTypeCache(Symbols.scala:3143) scala.reflect.internal.Symbols$TypeSymbol.tpe_$times(Symbols.scala:3120) scala.reflect.internal.Symbols$Symbol.tpe(Symbols.scala:1463) scala.tools.nsc.javac.JavaParsers$JavaParser.addAnnot$1(JavaParsers.scala:350) scala.tools.nsc.javac.JavaParsers$JavaParser.modifiers(JavaParsers.scala:386) scala.tools.nsc.javac.JavaParsers$JavaParser.typeBodyDecls(JavaParsers.scala:738) scala.tools.nsc.javac.JavaParsers$JavaParser.typeBody(JavaParsers.scala:728) scala.tools.nsc.javac.JavaParsers$JavaParser.classDecl(JavaParsers.scala:700) scala.tools.nsc.javac.JavaParsers$JavaParser.$anonfun$typeDecl$3(JavaParsers.scala:868) scala.tools.nsc.javac.JavaParsers$JavaParser$$Lambda$568/954745645.apply(Unknown Source) scala.tools.nsc.javac.JavaParsers$JavaParser.joinComment(JavaParsers.scala:138) scala.tools.nsc.javac.JavaParsers$JavaParser.typeDecl(JavaParsers.scala:868) scala.tools.nsc.javac.JavaParsers$JavaParser.compilationUnit(JavaParsers.scala:916) scala.tools.nsc.javac.JavaParsers$JavaParser.parse(JavaParsers.scala:49) scala.tools.nsc.ast.parser.SyntaxAnalyzer.scala$tools$nsc$ast$parser$SyntaxAnalyzer$$initialUnitBody(SyntaxAnalyzer.scala:85) scala.tools.nsc.ast.parser.SyntaxAnalyzer$ParserPhase.apply(SyntaxAnalyzer.scala:99) scala.tools.nsc.Global$GlobalPhase.scala$tools$nsc$Global$GlobalPhase$$processUnit(Global.scala:443) scala.tools.nsc.Global$GlobalPhase$$anonfun$1.$anonfun$applyOrElse$1(Global.scala:414) scala.tools.nsc.Global$GlobalPhase$$anonfun$1$$Lambda$427/1917083500.apply(Unknown Source) scala.concurrent.Future$.$anonfun$apply$1(Future.scala:608) scala.concurrent.Future$$$Lambda$428/1526009370.apply(Unknown Source) scala.util.Success.$anonfun$map$1(Try.scala:250) scala.util.Success$$Lambda$431/987128726.apply(Unknown Source) scala.util.Try$.apply(Try.scala:208) scala.util.Success.map(Try.scala:250) scala.concurrent.Future.$anonfun$map$1(Future.scala:244) scala.concurrent.Future$$Lambda$429/1226711664.apply(Unknown Source) scala.concurrent.impl.Promise.liftedTree1$1(Promise.scala:29) scala.concurrent.impl.Promise.$anonfun$transform$1(Promise.scala:29) scala.concurrent.impl.Promise$$Lambda$430/1319647571.apply(Unknown Source) scala.concurrent.impl.CallbackRunnable.run(Promise.scala:60) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) java.lang.Thread.run(Thread.java:745)

mkeskells · 2018-05-17T23:40:01Z

Its looking pretty good

I added some helper classes to https://github.com/rorygraves/scalac_perf/commits/mike/2.13.x_parallel_base in commit 2 that should ease some of the code I hope

mkeskells · 2018-05-21T21:05:04Z

src/compiler/scala/tools/nsc/Global.scala

 def reporter_=(newReporter: Reporter): Unit =
- currentReporter = newReporter match {
+ currentReporter.set(newReporter match {


assert Parallel.onMainThread?

Wouldn't be true.
We are setting new one for every unit now.
It's required to ensure consistent ordering of the logs.

mkeskells · 2018-05-21T21:34:21Z

src/compiler/scala/tools/nsc/Global.scala

 try {
+ if ((unit ne null) && unit.exists) lastSeenSourceFile = unit.source
 currentRun.currentUnit = unit


this needs to be parallel?

Unluckily yes, at least as long as we have currentUnit.
lastSeenSourceFile is used inside error reporting which happens inside worker thread.
If we would make it global it could report errors on incorrect files.

That said I do not understand why we need it in first place.
Comment in Global.scala says:

/** There are common error conditions where when the exception hits * here, currentRun.currentUnit is null. This robs us of the knowledge * of what file was being compiled when it broke. Since I really * really want to know, this hack. */ protected var lastSeenSourceFile: SourceFile = NoSourceFile

But i cannot see how lastSeenSourceFile can be set when currentRun.currentUnit is null.

mkeskells · 2018-05-21T21:36:32Z

src/compiler/scala/tools/nsc/backend/jvm/GenBCode.scala

@@ -66,11 +66,11 @@ abstract class GenBCode extends SubComponent {

 def apply(unit: CompilationUnit): Unit = codeGen.genUnit(unit)

- override def run(): Unit = {
+ override def wrapRun(code: => Unit): Unit = {


why do we need to change genBcode?

mkeskells · 2018-05-21T21:42:28Z

src/reflect/scala/reflect/api/Trees.scala

@@ -2463,7 +2464,9 @@ trait Trees { self: Universe =>
 * @group Traversal
 */
 class Traverser {


I wonder if all of these/some of these Traversers are thread local themselves.
Probably a bigger change thuogh and higher risk

mkeskells · 2018-05-21T21:47:07Z

src/reflect/scala/reflect/internal/Positions.scala

- var pos: Position
+ private val _pos: WorkerThreadLocal[Position] = WorkerThreadLocal(NoPosition)
+ @inline def pos: Position = _pos.get
+ @inline def pos_=(position: Position): Unit = _pos.set(position)
 }
 protected[this] lazy val posAssigner: PosAssigner = new DefaultPosAssigner


why not make this a thread local. BTW it has overrides

I thought it will require more changes exactly because of those overrides but when i tried now it turns out it's 3-lines-change. Fixed.

mkeskells · 2018-05-21T21:51:38Z

src/reflect/scala/reflect/internal/Reporting.scala

@@ -78,6 +78,8 @@ import util.Position
 */
 abstract class Reporter {
 protected def info0(pos: Position, msg: String, severity: Severity, force: Boolean): Unit
+ def info1(pos: Position, msg: String, severity: Severity, force: Boolean): Unit =


what is this?

With current design i still cannot access info0.
But I can make this protected[reporters].

mkeskells · 2018-05-21T21:52:57Z

src/reflect/scala/reflect/internal/util/Parallel.scala

+
+object Parallel {
+
+ class WorkerThread(group: ThreadGroup, target: Runnable, name: String,


we need a SingleThreadedWorker as dicussed on call

Running in the current thread is handled inside execution context in Global in the else block:

private def createExecutionContext(): ExecutionContextExecutor = { if (settings.YparallelPhases.containsPhase(this)) { val parallelThreads = settings.YparallelThreads.value val threadPoolFactory = ThreadPoolFactory(Global.this, this) val javaExecutor = threadPoolFactory.newUnboundedQueueFixedThreadPool(parallelThreads, "worker") ExecutionContext.fromExecutorService(javaExecutor, _ => ()) } else ExecutionContext.fromExecutor((task: Runnable) => asWorkerThread(task.run())) }

romanowski · 2018-05-30T15:43:45Z

src/compiler/scala/tools/nsc/Global.scala

+
+ if (isDebugPrintEnabled) inform("[running phase " + name + " on " + currentRun.size + " compilation units]")
+
+ implicit val ec: ExecutionContextExecutor = createExecutionContext()


I wonder why can't reuse the same executionContext across all phases - to create a treadpull is not a cheap operation IIRC

Good point, I don't see why we cant

no we cant - its wiring requires that we generate for each phase. The reuse or otherwise has to be managed by the async helper to get the instrumentation

mkeskells · 2018-05-30T19:08:44Z

src/compiler/scala/tools/nsc/Global.scala

 def reporter_=(newReporter: Reporter): Unit =
- currentReporter = newReporter match {
+ currentReporter.set(newReporter match {


we should assert that we are on the main thread I think

That is not the case here, please look into processUnit method.

mkeskells · 2018-05-30T19:20:59Z

src/compiler/scala/tools/nsc/Global.scala

- currentRun.informUnitStarting(this, unit)
- try withCurrentUnitNoLog(unit)(task)
- finally currentRun.advanceUnit()
+ def run(): Unit = {


can we keep the methods in the same order as original

mkeskells · 2018-05-30T19:26:06Z

src/compiler/scala/tools/nsc/Global.scala

 currentRun.currentUnit = unit
- task
+ _synchronizeNames = isParallel


why are we changing this on a worker thread?

mkeskells · 2018-05-30T19:26:30Z

src/compiler/scala/tools/nsc/Global.scala

 currentRun.currentUnit = unit0
+ currentRun.advanceUnit()
+ _synchronizeNames = false


Ah... you are right!
First thing i need to do at Monday is remove all excludes from my tool and replace them with some intelligent check for synchronization etc.

mkeskells · 2018-05-30T19:29:00Z

src/compiler/scala/tools/nsc/Global.scala

@@ -1058,12 +1129,6 @@ class Global(var currentSettings: Settings, reporter0: Reporter)
 */
 override def currentRunId = curRunId

- def echoPhaseSummary(ph: Phase) = {


what do we gain by changing this method. We need to keep the focus on the chnage, not optimisations and refactors that are orthoganal IMO

It's related to some extend.
I changed typer's run method to call super, previously it was re-implementing it.
echoPhaseSummary was one of the methods which are no longer needed when we are not re-implementing code from the run.

mkeskells · 2018-05-30T19:42:38Z

src/reflect/scala/reflect/api/Trees.scala

+ /** Access from multiple threads was reported by umad.
+ * That possibly could be solved by ensuring that every unit operates on it's own copy of the tree,
+ * but it would require much bigger refactorings and would be more memory consuming.
+ */


Maybe a traverser captures the currentUnit, or thread, and asserts that it is local
Maybe this is a followup investigation though

mkeskells · 2018-05-30T19:43:50Z

src/reflect/scala/reflect/api/Trees.scala

+ /** The current owner symbol.
+ *
+ * Access from multiple threads was reported by umad.
+ * That possibly could be solved by ensuring that every unit operates on it's own copy of the tree,


Maybe a transformer captures the currentUnit, or thread, and asserts that it is local
Maybe this is a followup investigation though

rorygraves

Looks good - I don't really have any comments above and beyond Mikes

mkeskells · 2018-05-30T20:51:13Z

src/reflect/scala/reflect/internal/util/Parallel.scala

+ // Runs block of the code in the 'worker thread' mode
+ // All unit processing should always happen in the worker thread
+ @inline final def asWorkerThread[T](fn: => T): T = {
+ val previous = isWorker.get()


do we need this to be reenterent?

It's not so much about being re-entrant as for cases when we have:

main execution

worker execution

main execution

happening on the same thread (tests, phases with disabled parallel compilation)

mkeskells · 2018-05-30T20:57:00Z

src/reflect/scala/reflect/internal/util/Parallel.scala

+ // it's much easier to start with assuming everything is initially worker thread
+ // and just mark main accordingly when needed.
+ private val isWorker: ThreadLocal[Boolean] = new ThreadLocal[Boolean] {
+ override def initialValue(): Boolean = true


I am not convinced that this is a safe assumption

would it be safer to have ismanaged as a threadlocal (default false) and set to true while in global.compileUnits

this could be a enabler for the other checks

I'm not sure if/why that would be safer.
I guess we need to discuss that.

mkeskells · 2018-05-30T21:11:17Z

src/reflect/scala/reflect/internal/util/Parallel.scala

+
+ // Asserts that current execution happens on the main thread
+ def assertOnMain(): Unit = {
+ assert(!isWorker.get())


!ismanaged.get() &&
??

mkeskells · 2018-05-30T21:12:13Z

src/reflect/scala/reflect/internal/util/Parallel.scala

+ }
+
+ // Wrapper for `synchronized` method. In future could provide additional logging, safety checks, etc.
+ def synchronizeAccess[T <: Object, U](obj: T)(block: => U): U = {


how about

class ThreadStats{ //may be useful to log from ProfilingThreadPoolFactory - ideally to perf_tester, but maybe just to console at the moment var uncontendedAccess = 0L var contendedAccess =0L var waitTime = 0L } object ThreadStats extends ThreadLocal[ThreadStats] { override def initialValue(): ThreadStats = new ThreadStats } final class ControlledAccess(name: String) { private val lock = new ReentrantLock(false) def apply[T] (block: => T) = { val stats = ThreadStats.get if (lock.tryLock()) stats.uncontendedAccess += 1 else { val startWait = System.nanoTime() lock.lock() val duration = System.nanoTime() - startWait stats.waitTime += duration stats.contendedAccess += 1 } try block finally lock.unlock } }

mkeskells · 2018-05-30T21:16:50Z

Looks very close 👍
just a few small comments. Lets discuss on Monday and squash this

…ertions

pkukielka and others added 2 commits May 17, 2018 14:56

Add option to run unit processing in parallel

236f59a

Parralelize parser phase

d467b59

pkukielka force-pushed the pkukielka/2.13.x-parallelize branch from 8ddd732 to d467b59 Compare May 17, 2018 15:17

mkeskells reviewed May 17, 2018

View reviewed changes

pkukielka force-pushed the pkukielka/2.13.x-parallelize branch from c4a8403 to 95cd8ed Compare May 21, 2018 16:25

Changes after review

daa26ac

pkukielka force-pushed the pkukielka/2.13.x-parallelize branch from 95cd8ed to daa26ac Compare May 21, 2018 16:32

mkeskells reviewed May 21, 2018

View reviewed changes

Bring back option to use main as worker

8c8ed97

mkeskells reviewed May 21, 2018

View reviewed changes

pkukielka and others added 5 commits May 22, 2018 10:09

Change executor for single threaded runs

440e154

Improve logger

b29bf28

Fix PosAssigner

8d149f6

Synchronize symbols

bf83254

Make logger behaviour dependin on if phase is parallel

37c92f6

pkukielka added 2 commits May 25, 2018 19:09

Fix tests

bc47681

Add comments

33a056d

pkukielka changed the title ~~[WIP] Initial structure and parallelization of parser~~ Initial structure and parallelization of parser May 30, 2018

pkukielka requested review from rorygraves and romanowski May 30, 2018 07:52

romanowski reviewed May 30, 2018

View reviewed changes

mkeskells reviewed May 30, 2018

View reviewed changes

rorygraves reviewed May 30, 2018

View reviewed changes

mkeskells reviewed May 30, 2018

View reviewed changes

pkukielka and others added 5 commits June 4, 2018 14:26

Inline more methods, fix _synchronizeNames, add option to disable ass…

1cb4641

…ertions

Fix futures

c32b177

Fix executor

4378e54

Await threads termination

4730ced

Fix profiler shutdown

736ba0b

		@@ -0,0 +1,39 @@
		package scala.tools.nsc.util

		object ThreadIdentityAwareThreadLocal {


		object Parallel {

		class WorkerThread(group: ThreadGroup, target: Runnable, name: String,


		if (isDebugPrintEnabled) inform("[running phase " + name + " on " + currentRun.size + " compilation units]")

		implicit val ec: ExecutionContextExecutor = createExecutionContext()

Initial structure and parallelization of parser #66

Are you sure you want to change the base?

Initial structure and parallelization of parser #66

Conversation

pkukielka commented May 17, 2018 • edited by rorygraves Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkeskells May 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkeskells commented May 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkukielka May 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkukielka May 23, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkeskells May 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rorygraves left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkukielka Jun 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkeskells commented May 30, 2018

pkukielka commented May 17, 2018 •

edited by rorygraves

Loading

mkeskells May 17, 2018 •

edited

Loading

pkukielka May 22, 2018 •

edited

Loading

pkukielka May 23, 2018 •

edited

Loading

mkeskells May 30, 2018 •

edited

Loading

pkukielka Jun 4, 2018 •

edited

Loading