Skip to content

Commit

Permalink
Updated WriteLog to always write the log on exceptions (#350)
Browse files Browse the repository at this point in the history
Updated BuildException usages to always include log data

Closes #349
  • Loading branch information
roryprimrose authored Aug 19, 2024
1 parent 7af0751 commit 4aed4fa
Show file tree
Hide file tree
Showing 7 changed files with 333 additions and 43 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
steps:

- name: Checkout
uses: actions/checkout@v4.1.1
uses: actions/checkout@v4.1.6
with:
fetch-depth: 0

Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:

- name: Generate coverage report
# run: reportgenerator -reports:**/coverage.cobertura.xml -targetdir:Report -reporttypes:HtmlInline_AzurePipelines;Cobertura
uses: danielpalme/ReportGenerator-GitHub-Action@5.2.3
uses: danielpalme/ReportGenerator-GitHub-Action@5.2.4
with:
reports: "**/coverage*cobertura.xml"
targetdir: "Report"
Expand All @@ -85,7 +85,7 @@ jobs:
run: dotnet pack "./${{ env.projectName }}/${{ env.projectName }}.csproj" -c Release --no-build --include-symbols -o $GITHUB_WORKSPACE/staging

- name: Publish build artifacts
uses: actions/upload-artifact@v4.3.1
uses: actions/upload-artifact@v4.3.3
with:
name: packages
path: staging
Expand All @@ -95,7 +95,7 @@ jobs:
run: |
echo '${{ steps.gitversion.outputs.NuGetVersionV2 }}' > version.txt
- name: Upload version
uses: actions/upload-artifact@v4.3.1
uses: actions/upload-artifact@v4.3.3
with:
name: version
path: version.txt
Expand All @@ -108,7 +108,7 @@ jobs:

steps:
- name: Download packages
uses: actions/download-artifact@v4.1.4
uses: actions/download-artifact@v4.1.7
with:
name: packages

Expand All @@ -129,12 +129,12 @@ jobs:
steps:

- name: Download packages
uses: actions/download-artifact@v4.1.4
uses: actions/download-artifact@v4.1.7
with:
name: packages

- name: Download version
uses: actions/download-artifact@v4.1.4
uses: actions/download-artifact@v4.1.7
with:
name: version

Expand Down
6 changes: 3 additions & 3 deletions ModelBuilder.UnitTests/ModelBuilder.UnitTests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
</PackageReference>
<PackageReference Include="NodaTime" Version="3.1.11" />
<PackageReference Include="nsubstitute" Version="5.1.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="xunit" Version="2.7.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.7">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
<PackageReference Include="xunit" Version="2.9.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
Expand Down
9 changes: 9 additions & 0 deletions ModelBuilder.UnitTests/Models/PropertySetFailure.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
namespace ModelBuilder.UnitTests.Models
{
using System;

internal class PropertySetFailure
{
public string Name { get => "Name"; set => throw new NotImplementedException(); }
}
}
Loading

0 comments on commit 4aed4fa

Please sign in to comment.