Interpretation of Type on ExecuteOrderRule is confusing and used in two different ways

[roryprimrose]

The DefaultBuildStrategyCompiler uses type on ExecuteOrderRules to identify the ordering of evaluation by property type. The DefaultExecuteStrategy uses the rules against the property type so this works as intended.

The expression extension methods however use the owning type of the property to register a rule. This work syntactically but is very broken when the rule is used by DefaultExecuteStrategy.

For example:

    public static partial class Create
    {
        public static T Model<T>()
        {
            var compiler = ModelBuilder.Model.BuildStrategy.Clone();

            compiler.AddExecuteOrderRule<Skill>(x => x.YearStarted, 4000);
            compiler.AddExecuteOrderRule<Skill>(x => x.YearLastUsed, 3000);

            compiler.AddValueGenerator<YearInPastValueGenerator>();

            var builder = compiler.Compile();

            return builder.Create<T>();
        }
    }

This should add order rules such that YearStarted is evaluated first and YearLastUsed is evaluated afterwards. The bug is that AddExecuteOrderRule creates an order rule against typeof(Skill) instead of typeof(int?) which is the property type determined from the expression.

Both scenarios are valid cases. There should be the option to target the ExecuteOrderRule against a property type as well as owning type of the property. This would cater for being able to run strings after enums for example, while also using expressions to target specific properties.