Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore self referencing property values #348

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

roryprimrose
Copy link
Owner

Updated DefaultPropertyResolver.IsIgnored to return true for a property value that references the owning instance

…ty value that references the owning instance
@roryprimrose roryprimrose enabled auto-merge (squash) August 11, 2024 10:44
Copy link

File Coverage
All files 97%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/BuildActions/CreationRuleBuildAction.cs 96%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/BuildActions/TypeCreatorBuildAction.cs 95%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/BuildActions/ValueGeneratorBuildAction.cs 95%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/CommonExtensions.cs 92%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/DefaultBuildLog.cs 97%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/DefaultConstructorResolver.cs 93%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/DefaultExecuteStrategy.cs 98%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/DefaultPropertyResolver.cs 98%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/DefaultTypeResolver.cs 98%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ExecuteOrderRules/ParameterPredicateExecuteOrderRule.cs 91%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ExecuteOrderRules/PropertyPredicateExecuteOrderRule.cs 91%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/Properties/Resources.Designer.cs 89%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/TypeCreators/ArrayTypeCreator.cs 84%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/TypeCreators/EnumerableTypeCreator.cs 98%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/TypeCreators/SingletonTypeCreator.cs 95%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/AgeValueGenerator.cs 96%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/CityValueGenerator.cs 90%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/EmailValueGenerator.cs 96%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/PhoneValueGenerator.cs 90%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/PostCodeValueGenerator.cs 90%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/RelativeValueGenerator.cs 97%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/StateValueGenerator.cs 90%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/TimeZoneValueGenerator.cs 96%
/home/runner/work/ModelBuilder/ModelBuilder/ModelBuilder/ValueGenerators/ValueGeneratorMatcher.cs 96%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 83663a1

@roryprimrose roryprimrose merged commit 7af0751 into main Aug 11, 2024
7 checks passed
@roryprimrose roryprimrose deleted the bugfix/347-SelfReferencingProperty branch August 11, 2024 10:44
@roryprimrose
Copy link
Owner Author

Closed #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create throws StackOverflowException when attempting to populate property that is self-referencing
1 participant