[CI] Use wf from ros2_control_ci for coverage build

[christophfroehlich]

Reusable workflow was added with ros-controls/ros2_control_ci#12

Together with #181 this closes #111

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.10%. Comparing base (759d954) to head (8daccf7).

Additional details and impacted files

@@             Coverage Diff              @@
##           ros2-master     #188   +/-   ##
============================================
  Coverage        50.10%   50.10%           
============================================
  Files               10       10           
  Lines              497      497           
  Branches           166      167    +1     
============================================
  Hits               249      249           
  Misses             217      217           
  Partials            31       31           

Flag	Coverage Δ
unittests	50.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[fmauch]

Seems fine the failing lottery seems unrelated.

[christophfroehlich]

Seems fine the failing lottery seems unrelated.

I'm not sure about this token now, the coverage workflow fails mentioning a missing codecov token, and it didn't get updated since the first commit in this PR :/

[fmauch]

Seems fine the failing lottery seems unrelated.

I'm not sure about this token now, the coverage workflow fails mentioning a missing codecov token, and it didn't get updated since the first commit in this PR :/

hm, you're right. The docs seem to be pretty clear about tokens, btw. Maybe we use v3 in those repos where it works without a token?

I am wondering why our CI job isn't failing. This one (in my own repo) does.

[christophfroehlich]

Seems fine the failing lottery seems unrelated.

I'm not sure about this token now, the coverage workflow fails mentioning a missing codecov token, and it didn't get updated since the first commit in this PR :/

hm, you're right. The docs seem to be pretty clear about tokens, btw. Maybe we use v3 in those repos where it works without a token?

I'm not sure why it doesn't work from my fork then (or why it worked only once to be precise). I'll open this PR in another repo and see what happens there. Maybe one from a fork and one from a branch of the repo itself.

No, we use v4
https://github.com/ros-controls/ros2_control/blob/c4affe4bbfbb12b947acfc7b268f529724e0aae8/.github/workflows/ci-coverage-build.yml#L45-L49

but we have the error there as well:
https://github.com/ros-controls/ros2_control/actions/runs/7964042229/job/21740799081

I'll have a look how to properly pass the secret, but it didn't work out when I tried it the first time.

I am wondering why our CI job isn't failing. This one (in my own repo) does.

Thanks for fixing this.

[christophfroehlich]

Something is wrong with the lcov/codecov paths, it now includes the header from generate_parameter_library

[christophfroehlich]

Seems to be fixed with ros-controls/ros2_control_ci#20, waiting for the merge