Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Aug 13, 2025

Resolves #442

I fixed the tests, we haven't tested all the parameters with initialize_from_ros_parameters


This is an automatic backport of pull request #443 done by Mergify.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.31%. Comparing base (862d687) to head (1d59cce).

Files with missing lines Patch % Lines
control_toolbox/src/pid_ros.cpp 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy     #445      +/-   ##
==========================================
+ Coverage   76.23%   76.31%   +0.07%     
==========================================
  Files          29       29              
  Lines        2066     2077      +11     
  Branches      125      129       +4     
==========================================
+ Hits         1575     1585      +10     
  Misses        420      420              
- Partials       71       72       +1     
Flag Coverage Δ
unittests 76.31% <92.30%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
control_toolbox/test/pid_ros_parameters_tests.cpp 100.00% <100.00%> (ø)
control_toolbox/src/pid_ros.cpp 59.24% <88.88%> (+0.61%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit aed2949 into jazzy Aug 13, 2025
12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-443 branch August 13, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants