Fix overriding of install

[tylerjw]

This PR cleans up a few things about the CMake but mostly it applies a fix for this: https://colcon.readthedocs.io/en/released/user/overriding-packages.html#how-to-make-it-easier-for-your-users-to-override

This is related to:

• Fix CMake install so overriding works ros2_control#926
• Fix overriding of install realtime_tools#105
• Fix overriding of install ros2_controllers#510

[destogl]

This is a quite opinionated review. I would like to discuss this here before we continue with other things.

[tylerjw]

@destogl I pushed a change restoring the THIS_PACKAGE_INCLUDE_DEPENDS list and using ament_target_dependencies instead of target_link_libraries. Do you prefer it like this?

[destogl]

Yes I like ti very much! Thanks for following up!

Let's wait to see what @bmagyar thinks about this before going to adjust all other PRs.

[bmagyar]

This is very neat guys, thanks a lot!

[tylerjw]

I'll fix the format job here too if you want me to.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@01a2cda). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3ad2264 differs from pull request most recent head 069c91e. Consider uploading reports for the commit 069c91e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage          ?   31.11%           
=========================================
  Files             ?        2           
  Lines             ?      180           
  Branches          ?      116           
=========================================
  Hits              ?       56           
  Misses            ?       20           
  Partials          ?      104           

Flag	Coverage Δ
unittests	31.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[destogl]

I fixed it in another PR and updated all the hooks. So would be great if you could rebase this when I merge another when then I'll merge this

[destogl]

OK, I merge master here. Now we have very clean PR. If CI is happy I am merging this!