Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User unique_ptr in ResourceManager #186

Closed
destogl opened this issue Oct 7, 2020 · 1 comment
Closed

User unique_ptr in ResourceManager #186

destogl opened this issue Oct 7, 2020 · 1 comment

Comments

@destogl
Copy link
Member

destogl commented Oct 7, 2020

consider to put them in the initializer list with std::make_shared / std::make_unique.
But first, why are these shared pointer and not unique pointers, and second, why are these pointers in the first place?

Originally posted by @Karsten1987 in #147 (comment)

I started porting stuff from @Karsten1987 from #165 but it was not tivial. If someone wants to continue I uploaded this changes here: https://github.com/destogl/ros2_control/pull/new/adding_resource_storage

@destogl
Copy link
Member Author

destogl commented Nov 18, 2020

obsolete...

@destogl destogl closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant