Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create descriptions for robots from examples #5

Open
2 of 3 tasks
destogl opened this issue May 6, 2020 · 6 comments
Open
2 of 3 tasks

Create descriptions for robots from examples #5

destogl opened this issue May 6, 2020 · 6 comments
Assignees

Comments

@destogl
Copy link
Member

destogl commented May 6, 2020

Following should be done (add additional items if needed):

  • define description for rrbot in the description folder (existing 2dof can be reused)
  • create *.ros2_control.xacro for each robot type
  • prepare full xacro for the robot
@destogl destogl self-assigned this Jun 2, 2020
@destogl
Copy link
Member Author

destogl commented Jun 2, 2020

Check descriptions of
demo_robot.yaml
demo_robot_minimal.yaml
in #21
@olivier-stasse : how does this looks to you?

@destogl
Copy link
Member Author

destogl commented Jun 16, 2020

@olivier-stasse here is something I would need help with, so if you have some time I would be very thankful :)

Current state

  • in Add initial package structure #4 there is initial implementation of DemoRobot with URDF and xacro file
  • I had problems with parsing xacro files in ROS2, therefore is comment about that in ros2_control_demo_robot/launch/minimal_robot.launch.py
  • I solved it by generating URDF in ROS1 and then using it directly

What are next steps

  • Use xacro file directly in ROS2
  • Launch also robot_state_publisher
  • Visualizes the MinimalRobot in rviz and check if the description make sense (test using joint_state_publisher is probably the easiest)
  • Provide some fake funcitonality in DemoRobotHardwareMinimal class

When this works we should than concentrate on manager node and adding another examples.

Is this OK for you?

@olivier-stasse
Copy link
Collaborator

Sounds good !
I will give it try.

@Karsten1987
Copy link
Contributor

I don't think it makes sense to parse xacro files. I think it makes sense to expect the robot_description to be presented as xml and therefore be parsed as such.

@destogl
Copy link
Member Author

destogl commented Jun 17, 2020

Oh, I wrote that confusing...

I meant not to parse xacro file manually, but to convert it automatically in launch file into URDF file.

this didn‘t work for me with xacro in ROS2 for unknown reasons...

@destogl destogl changed the title Create description for demo_robot Create descriptions for robots from examples Aug 21, 2020
@destogl
Copy link
Member Author

destogl commented Sep 11, 2020

Full list of examples: source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants