Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Is acceleration-only command interface setup useful? #701

Closed
christophfroehlich opened this issue Jul 14, 2023 · 2 comments · Fixed by #770
Closed

[JTC] Is acceleration-only command interface setup useful? #701

christophfroehlich opened this issue Jul 14, 2023 · 2 comments · Fixed by #770
Assignees
Labels

Comments

@christophfroehlich
Copy link
Contributor

The validator does not allow acceleration-only command interfaces:

// Check if command interfaces combination is valid. Valid combinations are:
// 1. effort
// 2. velocity
// 2. position [velocity, [acceleration]]

I'm not sure if this would make sense, i.e., if there is any robot type with acceleration-only interface, but I think JTC could work with it.

  • Should we allow it?
  • If not -> I'll clarify that in the docs, because this is not clearly described there.
@destogl
Copy link
Member

destogl commented Sep 9, 2023

You are right. If we have effort, then acceleration is not necessary. People using direct control of joint moments will use rather effort than acceleration.

So I am arguing to disable that.

@christophfroehlich
Copy link
Contributor Author

Thanks for the info, I'll write an update for the docs for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants