Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering controllers library open_loop mode #784

Closed
christophfroehlich opened this issue Sep 29, 2023 · 0 comments · Fixed by #793
Closed

Steering controllers library open_loop mode #784

christophfroehlich opened this issue Sep 29, 2023 · 0 comments · Fixed by #793
Labels

Comments

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Sep 29, 2023

Describe the bug
The open_loop mode of the steering controllers library is not working.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout the CarLike demo [Example 11] Carlike Robot using Bicycle Steering Controller ros2_control_demos#316
  2. Set the open_loop parameter to true
  3. Check the results, the robot is not moving.

Expected behavior
Ideal odometry

Environment (please complete the following information):

  • Version : Rolling

Additional context
I think the issue is that the variables here are never set

// store last velocity
double last_linear_velocity_ = 0.0;
double last_angular_velocity_ = 0.0;

but used here
odometry_.update_open_loop(last_linear_velocity_, last_angular_velocity_, period.seconds());

odometry_.update_open_loop(last_linear_velocity_, last_angular_velocity_, period.seconds());

odometry_.update_open_loop(last_linear_velocity_, last_angular_velocity_, period.seconds());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant