Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New style exceptions for Python 3 #52

Closed
wants to merge 1 commit into from
Closed

New style exceptions for Python 3 #52

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 12, 2018

Python 3 treats old style exceptions as syntax errors.

New style exceptions for Python 3
fd09a6e 
Python 3 treats old style exceptions as syntax errors.
k-okada
k-okada approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and this should work on python2 too.

@cclauss
Copy link
Contributor Author

cclauss commented Jul 21, 2018

@k-okada What is the next step on this one?

@cclauss cclauss closed this Nov 24, 2019
@cclauss cclauss deleted the patch-1 branch November 24, 2019 15:45
cclauss added a commit to cclauss/axis_camera that referenced this pull request May 12, 2020
@cclauss
Fix Python 3 syntax error
2dabea0 
ros-drivers#52 again
@cclauss cclauss mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @k-okada