Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only access camera with correct serial #202

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

berndpfrommer
Copy link
Collaborator

This PR addresses issue #201 related to PR #195.
The hope is that initializing only the camera with the proper serial number will not upset other FLIR cameras served by a different driver.

Could @iag0g0mes please test if this works correctly for your case of multiple interfaces?

@iag0g0mes
Copy link
Contributor

Hello,

This version worked well!

I was wondering if the issue with the last modification was related to adding all detected cameras to the CameraList. I recall reading a recommendation regarding multiple cameras, suggesting that the SDK has some limitations in this area.

Do you think this could be the cause of the unexpected behavior? Perhaps CameraList creates some kind of lock on the devices. I'm not sure, as the documentation isn't very clear on this.

Anyway, thank you very much for your help!

@berndpfrommer
Copy link
Collaborator Author

Thanks much for testing, I will merge this one now.
I believe the problem seen in #201 comes from the init / deinit calls, which are performed on all cameras, not just the one that is supposed to be used. The SDK seems to reset the devices on either one of the calls, which then destroys the associated /dev/video device.

@berndpfrommer berndpfrommer merged commit 30c8e0c into humble-devel Jul 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants