Fix CMake error caused by multiple JsonCpp target definitions #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: audrow <audrow@google.com>
SteveMacenski
approved these changes
Aug 23, 2024
I can do the release after I eat lunch |
|
Wonderful - thanks for moving so fast on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a CMake error that occurs when building ros2_ouster_drivers on Humble due to multiple definitions of the JsonCpp::JsonCpp target. The issue is caused by an upstream bug in JsonCpp (open-source-parsers/jsoncpp#1356) and is triggered when multiple dependencies attempt to find and link against jsoncpp.
Here's an example of an error on the buildfarm:
https://build.ros2.org/view/Hbin_uJ64/job/Hbin_uJ64__ros2_ouster__ubuntu_jammy_amd64__binary/89/
@SteveMacenski, would you be able to help get this in?