Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled dynamic reconfiguration of usb_cam_node #185

Merged
merged 2 commits into from
May 6, 2022

Conversation

progtologist
Copy link
Contributor

This allows the parameters of the usb_cam_node to be dynamically adjustable using either ros2 param set or rqt_reconfigure.

@flynneva flynneva self-requested a review April 26, 2022 02:19
@flynneva
Copy link
Collaborator

flynneva commented May 1, 2022

@progtologist just want to let you know I haven't forgotten about this. Going to test it out hopefully tomorrow and approve.

Copy link
Collaborator

@flynneva flynneva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment

src/usb_cam_node.cpp Outdated Show resolved Hide resolved
Co-authored-by: Evan Flynn <6157095+flynneva@users.noreply.github.com>
@flynneva flynneva self-requested a review May 6, 2022 23:34
@flynneva flynneva merged commit 4480637 into ros-drivers:ros2 May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants