Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Symlinks #311

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Resolve Symlinks #311

merged 3 commits into from
Jan 20, 2024

Conversation

firesurfer
Copy link
Contributor

@firesurfer firesurfer commented Jan 15, 2024

See #310

EDIT:
This PR solves only half of the problem. In order to fully solve the problem I think we should not do any assumptions on how the video device is actually called.

The reason for this edit is that we usually work with docker containers. We only mount our /dev/camerax devices into the container and not the /dev/videox. Additionally if mounted via --device a symlink in dev becomes a normal file entry in dev in the container.

This PR at least solves the problem if /dev/videox exists and /dev/camerax (or whatever the symlink is called) exists in /dev.

@flynneva flynneva self-requested a review January 15, 2024 14:32
@flynneva
Copy link
Collaborator

@firesurfer changes lgtm just I think CI failed because of a missing space between the // and comment.

Once you fix that I'll approve and merge this in

@firesurfer
Copy link
Contributor Author

I just saw that the package does not provide a .clang-format file. Perhaps it might be useful to provide one. Because I have .clang-format in my workspace I use for our internal package which is then used by clang format.
I try to fix the formatting manually for now.

@flynneva
Copy link
Collaborator

@firesurfer I just fixed the linter errors here, I'll wait for CI to pass then merge this in.

Regarding clang format: feel free to make a PR to enable it.

For now we use the ros2 defaults (cpplint and uncrustify). To fix your linter errors here I just ran the command ament_uncrustify --reformat from within the usb_cam directory and it fixed the linter errors.

@flynneva flynneva merged commit e2b11ab into ros-drivers:ros2 Jan 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants