Refactor and cleanup of codebase #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Levi-Armstrong: could you take a look at this one as well? It's probably less involved than it seems. There are no functional changes. |
|
+1; Looks great, OK to merge! |
This is a significant refactoring, which is intended to reduce the nr of include dependencies in all source and header files. Forward declaration of classes is used as much as possible, and includes have been moved to the cpp files as much as possible as well. This greatly increases locality of changes, resulting in shorter compilaton times whenever changes have been made to any of the class definitions as it avoids rippling significantly. Initial compilation is slightly slower, but that is considered an acceptable trade-off.
- sort depends, source and header lists - don't export include directories (this is a top-level application) - fix indent (minor)
gavanderhoorn
force-pushed
the
refactor_and_cleanup
branch
from
4e24631 to
8c24b4d
Compare
|
Ended up doing it in reversed order: first #73 and #72, then this one. @Levi-Armstrong: thanks for taking a look 👍. |
This was referenced Apr 19, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of the current codebase (
indigo-devel@ a80155e).Header (include) dependencies have been reduced as much as possible across all files and all property classes have been split into separate files. This greatly increases locality of changes as it reduces rippling, leading to much shorter edit-compile-run-test cycles when developing.