Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused min/max_payload parameters #289

Open
miguelprada opened this issue Apr 10, 2019 · 5 comments
Open

Unused min/max_payload parameters #289

miguelprada opened this issue Apr 10, 2019 · 5 comments
Labels
bug help wanted kinetic Issues with the refactor in Kinetic

Comments

@miguelprada
Copy link
Contributor

This package's launch files expose min_payload and max_payload arguments, which are used to set equally named parameters, but those parameters are not used anywhere.

@gavanderhoorn
Copy link
Member

Those were supported in the master version (which got it from ur_driver), but apparently @Zagitta didn't implement the checks:

https://github.com/ros-industrial/ur_modern_driver/blob/77fa08ae9c846344310d3b50824a7affdc3eda47/include/ur_modern_driver/ros/io_service.h#L65-L70

@miguelprada miguelprada added the kinetic Issues with the refactor in Kinetic label Apr 10, 2019
@gavanderhoorn
Copy link
Member

I added help wanted as this could be a good first issue for someone to tackle.

@gavanderhoorn gavanderhoorn added the wrid19 World ROS-Industrial Day 2019 label Jun 29, 2019
@dejaniraai dejaniraai assigned dejaniraai and unassigned dejaniraai Jul 2, 2019
@gavanderhoorn
Copy link
Member

Did you make any progress here @ben-greenberg?

@ben-greenberg
Copy link

I have made progress but some further work and testing is still needed. I will be continuing my work on this.

@gavanderhoorn
Copy link
Member

I'm going to unassign this @ben-greenberg.

You're welcome to keep working on it of course.

@gavanderhoorn gavanderhoorn removed the wrid19 World ROS-Industrial Day 2019 label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted kinetic Issues with the refactor in Kinetic
Projects
None yet
Development

No branches or pull requests

4 participants