Create CONTRIBUTING.md #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalocasas
suggested changes
Jul 12, 2018
| * Resolves package dependencies using rosdep (i.e. install packages using apt-get). | ||
| * Compiles the catkin workspace. | ||
| * Runs all available unit tests. | ||
| 5. If the PR passes Travis CI and one of the maintainers is satisfied with the changes, they post a +1 as a comment on the PR (item 5). The +1 signifies that the PR is ready to be merged. All PRs require at least one +1 and pass Travis CI before it can be merged. |
There was a problem hiding this comment.
Github has proper support for accepting a PR / requesting changes. Using the old style of commenting +1s or LGMT would not be the best recommendation.
There was a problem hiding this comment.
Certainly that's a little out of date. Maybe a more updated version could be created in ros-industrial/ros_industrial_issues#26 and propagated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: ros-industrial/ros_industrial_issues#26