Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IRB1600 10/1.45, add opw config for IRB1600 10/1.45, 8/1.45 and 6/1.2 #137

Open
wants to merge 6 commits into
base: kinetic-devel
Choose a base branch
from

Conversation

cjue
Copy link
Contributor

@cjue cjue commented Jun 29, 2022

Update reference document in package.xml

Add mesh for the 1.45 variant of link2, with scale 0.001 and transform -.150, -0.4865, -115

Rename files fo irb1600 6/1.2 for clarity.

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Jul 9, 2022

Add mesh for the 1.45 variant of link2, with scale 0.001 and transform -.150, -0.4865, -115

have you since updated the PR? I don't see this scaling.

(if it was there, I would've asked you to scale the .stl itself though)

Rename files fo irb1600 6/1.2 for clarity.

only the roslaunch_test .xml, correct?

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

I've left one in-line comment. Could you take a look?

abb_irb1600_support/urdf/irb1600_10_145_macro.xacro Outdated Show resolved Hide resolved
@gavanderhoorn
Copy link
Member

Friendly ping @cjue ?

@cjue
Copy link
Contributor Author

cjue commented Aug 30, 2022

I just noticed that #136 has introduced the irb1600 8/1.45 in the meantime.

Interesting tidbit: the IRB1600 10/1.45 is a re-release / "upgrade" of the IRB1600 8/1.45 that's identical except for payload and velocity limits.

Revision U: "IRB 1600-8 upgraded to 10 kg"

Source: https://search.abb.com/library/Download.aspx?DocumentID=3HAC023604-001&LanguageCode=en&

I updated both 1.45 urdfs to use the same link_2 meshes.

@cjue
Copy link
Contributor Author

cjue commented Aug 31, 2022

Add mesh for the 1.45 variant of link2, with scale 0.001 and transform -.150, -0.4865, -115

have you since updated the PR? I don't see this scaling.

(if it was there, I would've asked you to scale the .stl itself though)

I meant to say this was how I got from the STEP file to the mesh. It's also wrong, as I found out.

When comparing my link_2 mesh with the 8/1.45 version I noticed that I had set the origin incorrectly, placing link_2 inside the neighboring joints. This PR now uses the correct mesh for both the 8/1.45 and the 10/1.45.

Rename files fo irb1600 6/1.2 for clarity.

only the roslaunch_test .xml, correct?

Yes, the other files already had the model name in there.

@cjue cjue force-pushed the add-irb1600_10/1.45 branch from 4c41010 to dd11aa0 Compare August 31, 2022 08:40
@cjue cjue requested a review from gavanderhoorn August 31, 2022 09:14
@cjue
Copy link
Contributor Author

cjue commented Aug 31, 2022

Just a note: This PR does not touch the J23_coupled settings, but #139 will affect all IRB1600 models.

@cjue cjue changed the title add IRB1600 10/1.45, add opw config for IRB1600 10/1.45 and 6/1.2 add IRB1600 10/1.45, add opw config for IRB1600 10/1.45, 8/1.45 and 6/1.2 Sep 21, 2022
@cjue cjue force-pushed the add-irb1600_10/1.45 branch from dd11aa0 to b395be9 Compare September 21, 2022 08:14
@cjue
Copy link
Contributor Author

cjue commented Sep 21, 2022

closing and reopening to nudge checks

@cjue cjue closed this Sep 21, 2022
@cjue cjue reopened this Sep 21, 2022
@cjue cjue force-pushed the add-irb1600_10/1.45 branch from b395be9 to 079c203 Compare October 5, 2022 12:45
@cjue
Copy link
Contributor Author

cjue commented Oct 11, 2022

Friendly ping @cjue ?

ping addressed @gavanderhoorn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants