switch to new version of industrial_ci #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathias-luedtke
force-pushed
the
patch-1
branch
from
b263ab3
to
af1639f
Compare
mathias-luedtke
changed the title
|
af1639f could get reverted later |
|
@ipa-mdl: would you recommend we merge this PR in here? Are you satisfied with the stability of the new version or are there changes you'd like to integrate before switching over? |
for now it is a beta version, it's up to the maintainer
I would say it is stable, I don't expect any breaking changes.
I'd like to refactor it even further, but mostly under the hood. |
|
Some of this seems to be included in #69. After merging that PR, we should see which parts of this one are still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros-industrial/industrial_ci#390