Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS_DISTRO not supported with all images set in DOCKER_IMAGE #212

Closed
asmodehn opened this issue Aug 4, 2017 · 3 comments
Closed

ROS_DISTRO not supported with all images set in DOCKER_IMAGE #212

asmodehn opened this issue Aug 4, 2017 · 3 comments

Comments

@asmodehn
Copy link

asmodehn commented Aug 4, 2017

Setting up to use the DOCKER_IMAGE, I get :

**Setting environment variables from .travis.yml**
$ export VERBOSE_OUTPUT=true
$ export DOCKER_IMAGE=indigo-trusty-shadow-fixed
$ bash -c 'echo $BASH_VERSION'
4.3.11(1)-release

$ git clone https://github.com/ros-industrial/industrial_ci.git .ci_config
Cloning into '.ci_config'...
remote: Counting objects: 1479, done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 1479 (delta 0), reused 2 (delta 0), pack-reused 1475
Receiving objects: 100% (1479/1479), 431.98 KiB | 0 bytes/s, done.
Resolving deltas: 100% (934/934), done.

$ .ci_config/travis.sh
ROS distro '' is not supported

But ROS distro should not be needed since I specified DOCKER_IMAGE.
@asmodehn
Copy link
Author

asmodehn commented Aug 4, 2017

Ref : https://travis-ci.org/asmodehn/pyros-test/jobs/260854793

@mathias-luedtke
Copy link
Member

But ROS distro should not be needed since I specified DOCKER_IMAGE.

This does not hold for all images, e.g. the ros:* images don't set this.
We could try to set them in our images.

130s added a commit to 130s/industrial_ci that referenced this issue Sep 21, 2017
@130s
[doc] Small elaboration for Docker image usage (address ros-industria…
db9df37 
…l#212).
@130s 130s mentioned this issue Sep 21, 2017
Merged
130s added a commit to 130s/industrial_ci that referenced this issue Sep 30, 2017
@130s
[doc] Small elaboration for Docker image usage (address ros-industria…
757b57e 
…l#212).
130s added a commit to 130s/industrial_ci that referenced this issue Oct 2, 2017
@130s
[doc] Small elaboration for Docker image usage (address ros-industria…
8d29dd8 
…l#212).

[doc] Wrong rst format.
[doc] Clarify Docker image requirement.
130s added a commit to 130s/industrial_ci that referenced this issue Oct 18, 2017
@130s
[doc] Small elaboration for Docker image usage (address ros-industria…
9aa2c49 
…l#212).

[doc] Wrong rst format.
[doc] Clarify Docker image requirement.
130s added a commit to 130s/industrial_ci that referenced this issue Oct 20, 2017
@130s
[doc] Small elaboration for Docker image usage (address ros-industria…
c1431c8 
…l#212).

[doc] Wrong rst format.
[doc] Clarify Docker image requirement.
@mathias-luedtke mathias-luedtke mentioned this issue May 21, 2018
Merged
@130s 130s mentioned this issue Jul 11, 2018
Closed
@130s 130s changed the title ROS distro '' not supported with DOCKER_IMAGE ROS_DISTRO not supported with all images set in DOCKER_IMAGE Dec 20, 2018
@130s
Copy link
Member

130s commented Dec 20, 2018

Addressed by #280

@130s 130s closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asmodehn @mathias-luedtke @130s