Silence rosdep #152
Merged
Silence rosdep #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130s
reviewed
Mar 23, 2017
| @@ -117,7 +117,12 @@ fi | |||
|
|
|||
| ici_time_start rosdep_install | |||
|
|
|||
| rosdep install -q --from-paths $CATKIN_WORKSPACE --ignore-src --rosdistro $ROS_DISTRO -y | |||
| function rosdep_install { | |||
There was a problem hiding this comment.
What for is this a function? Are we going to reuse this somewhere?
There was a problem hiding this comment.
Actually this is a little hack to make the job fail if rosdep fails.
As an alternative I could have surrounded it with
set -o pipefail
set +o pipefail
Hwoever, I plan to factor all code into functions anyway.
There was a problem hiding this comment.
I see. Could you then leave a short inline comment for that hack?
There was a problem hiding this comment.
I have switched to pipefail and added a comment
mathias-luedtke
force-pushed
the
more-silence
branch
from
2f3c2e0
to
f545eac
Compare
130s
approved these changes
Mar 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters most of the rosdep install output, just prints commands and errors.
closes #141