Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test external projects again #169

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

mathias-luedtke
Copy link
Member

@mathias-luedtke mathias-luedtke commented May 5, 2017

This PR introduces a new feature for internal-use.
it can be used to run industrial_ci for external repositories, just as travis would do.
That's why I have introduced an internal script _wrap_test.sh.

@Jmeyer1292, @shaun-edwards, @gavanderhoorn, @ipa-fxm, @130s: Do you have some suggestions for other candidates?
In the end it should be a nice mix of ~5 external repos.

@mathias-luedtke mathias-luedtke force-pushed the feature/external-tests branch 3 times, most recently from 3c90548 to 07aa192 Compare May 6, 2017 11:26
@gavanderhoorn
Copy link
Member

Hm. What sort of repositories are you looking for?

Would anything do, or are we trying to cover specific testing scenarios fi?

@mathias-luedtke
Copy link
Member Author

Hm. What sort of repositories are you looking for?

The more complicated ones..
Our default test cases cover most of the regular stuff though.

or are we trying to cover specific testing scenarios fi?

  • not released
  • special dependencies (not resolved by rosdep)
  • creative before script usage
  • custom targets apart from regular executables and libraries
  • special unit tests
  • ...

industrial_core would be the candidate for the regular / simple repositories.

@mathias-luedtke mathias-luedtke force-pushed the feature/external-tests branch 2 times, most recently from e071c3f to 3b9e651 Compare July 27, 2017 13:41
@mathias-luedtke mathias-luedtke changed the title test external projects in pull requests test external projects again Jul 27, 2017
@mathias-luedtke mathias-luedtke force-pushed the feature/external-tests branch from 3b9e651 to 79e0b85 Compare July 27, 2017 14:26
@mathias-luedtke
Copy link
Member Author

I have remove godel as it takes almost 30 minutes to build.

@130s: I'd like to merge it soon, please review.

@mathias-luedtke mathias-luedtke requested a review from 130s July 27, 2017 14:28
Copy link
Member

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introducing _EXTERNAL_REPO is a good idea as it clarifies the jobs that are using repositories external from industrial_ci repo.

Just curious, what does wrap test mean?

@130s 130s merged commit 07e72c2 into ros-industrial:master Jul 27, 2017
@mathias-luedtke
Copy link
Member Author

Just curious, what does wrap test mean?

It's a wrapper for the actual travis test that adds the external repo feature.

@mathias-luedtke mathias-luedtke deleted the feature/external-tests branch July 27, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants