-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple GitHub deploy key mappings with GitHub Actions #815
base: master
Are you sure you want to change the base?
Conversation
…rwarding Add support for multiple GitHub deploy key mappings with GitHub Actions
ici_forward_mount /home/runner/.gitconfig rw | ||
ici_forward_mount /home/runner/.ssh rw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot hardcode Gihub-specific paths.
Please try adding .gitconfig here:
And why would we mount them rw? |
I think we could just add
|
|
@TrevorGibson-SR: The latest version should copy |
Proposed as a solution to #807
When cloning multiple private GitHub repositories with SSH, you can use the deploy key mapping feature of the webfactory/ssh-agent GitHub action to map specific SSH keys to their respective GitHub repositories. This works as intended when cloning in the main GitHub runner environment, but fails to translate over to the industrial_ci docker environment.
Webfactory/ssh-agent specifically calls this out and suggests to copy the
~/.ssh
directory and~/.gitconfig
file into the docker container to ensure the mappings are carried over. This change simply adds two new docker mount arguments to import the SSH configuration into the Docker container's build environment.