Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix catkin_make on kinetic-devel #169

Merged
merged 1 commit into from Jan 16, 2017
Merged

Fix catkin_make on kinetic-devel #169

merged 1 commit into from Jan 16, 2017

Conversation

VictorLamoine
Copy link
Contributor

Fixes #168

@VictorLamoine
Copy link
Contributor Author

VictorLamoine commented Jan 16, 2017 •
edited
Loading

So we didn't see this issue because Travis CI only builds with catkin tools. I realized this when using industrial_core in my GitLab CI: https://gitlab.com/InstitutMaupertuis/fanuc_motion/pipelines/5841251

@gavanderhoorn
Copy link
Member

Yep. industrial_ci doesn't do a build with catkin_make (anymore).

@130s, @ipa-mdl.

@mathias-luedtke
Copy link
Member

mathias-luedtke commented Jan 16, 2017 •
edited
Loading

industrial_ci doesn't do a build with catkin_make (anymore).

Yes, this is broken. We could add it again after the refactoring (ros-industrial/industrial_ci#98)

In addition industrial_ci disables all metapackages for some reason..

@gavanderhoorn gavanderhoorn merged commit efbaaa2 into ros-industrial:kinetic-devel Jan 16, 2017
@gavanderhoorn
Copy link
Member

Note: this is a partial revert of #161.

@mathias-luedtke mathias-luedtke mentioned this pull request Jan 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VictorLamoine @gavanderhoorn @mathias-luedtke