Skip to content

Commit

Permalink
Removed Duplicate Meshes
Browse files Browse the repository at this point in the history
Link meshes for the MH5L matching those of the MH5 were removed.
Effected URDF references redirected to MH5 meshes.
Moved unique "link-s" mesh to dedicated mh5_old_variants directory.
Updated changelog to reflect shared meshes.
  • Loading branch information
acbuynak committed Feb 2, 2021
1 parent 89820d5 commit a208a35
Show file tree
Hide file tree
Showing 13 changed files with 13 additions and 11 deletions.
2 changes: 1 addition & 1 deletion motoman_mh5_support/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Changelog for package motoman_mh5_support
0.3.6 (UNRELEASED)
------------------
** Added support for MH5 SHORT and LONG variants
* Each variant has unique launch, test, urdf, and mesh files. Only config/joint_names is shared.
* Each variant has unique launch, test, urdf, and (L & U) mesh files. Config/joint_names and remaining mesh files are shared.
* Fixed collision meshes
* Fixed tab/spacing in all code
* Renamed links & joints to ros-i convention
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed motoman_mh5_support/meshes/mh5l/visual/link_1_s.stl
Binary file not shown.
Binary file removed motoman_mh5_support/meshes/mh5l/visual/link_5_b.stl
Binary file not shown.
Binary file removed motoman_mh5_support/meshes/mh5l/visual/link_6_t.stl
Binary file not shown.
2 changes: 2 additions & 0 deletions motoman_mh5_support/urdf/mh5_macro.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,15 @@
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5/visual/link_3_u.stl"/>
<!-- <mesh filename="package://motoman_mh5_support/meshes/mh5_old_variants/visual/link_3_u.stl"/> --><!-- Uncomment & switch with above to use alternative U-link. -->
</geometry>
<material name="yaskawa_white"/>
</visual>
<collision>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5/collision/link_3_u.stl" />
<!-- <mesh filename="package://motoman_mh5_support/meshes/mh5_old_variants/collision/link_3_u.stl" /> --><!-- Uncomment & switch with above to use alternative U-link. -->
</geometry>
</collision>
</link>
Expand Down
20 changes: 10 additions & 10 deletions motoman_mh5_support/urdf/mh5l_macro.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -12,29 +12,29 @@
<visual>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/visual/base_link.stl" />
<mesh filename="package://motoman_mh5_support/meshes/mh5/visual/base_link.stl" />
</geometry>
<material name="yaskawa_white"/>
</visual>
<collision>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/collision/base_link.stl" />
<mesh filename="package://motoman_mh5_support/meshes/mh5/collision/base_link.stl" />
</geometry>
</collision>
</link>
<link name="${prefix}link_1_s">
<visual>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/visual/link_1_s.stl"/>
<mesh filename="package://motoman_mh5_support/meshes/mh5/visual/link_1_s.stl"/>
</geometry>
<material name="yaskawa_white"/>
</visual>
<collision>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/collision/link_1_s.stl" />
<mesh filename="package://motoman_mh5_support/meshes/mh5/collision/link_1_s.stl" />
</geometry>
</collision>
</link>
Expand All @@ -57,14 +57,14 @@
<visual>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/visual/link_3_u.stl"/>
<mesh filename="package://motoman_mh5_support/meshes/mh5/visual/link_3_u.stl"/>
</geometry>
<material name="yaskawa_white"/>
</visual>
<collision>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/collision/link_3_u.stl" />
<mesh filename="package://motoman_mh5_support/meshes/mh5/collision/link_3_u.stl" />
</geometry>
</collision>
</link>
Expand All @@ -87,29 +87,29 @@
<visual>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/visual/link_5_b.stl"/>
<mesh filename="package://motoman_mh5_support/meshes/mh5/visual/link_5_b.stl"/>
</geometry>
<material name="yaskawa_white"/>
</visual>
<collision>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/collision/link_5_b.stl" />
<mesh filename="package://motoman_mh5_support/meshes/mh5/collision/link_5_b.stl" />
</geometry>
</collision>
</link>
<link name="${prefix}link_6_t">
<visual>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/visual/link_6_t.stl" />
<mesh filename="package://motoman_mh5_support/meshes/mh5/visual/link_6_t.stl" />
</geometry>
<material name="yaskawa_white"/>
</visual>
<collision>
<origin xyz="0 0 0" rpy="0 0 0" />
<geometry>
<mesh filename="package://motoman_mh5_support/meshes/mh5l/collision/link_6_t.stl" />
<mesh filename="package://motoman_mh5_support/meshes/mh5/collision/link_6_t.stl" />
</geometry>
</collision>
</link>
Expand Down

0 comments on commit a208a35

Please sign in to comment.