Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing 'version0' to launch file #50

Closed
wants to merge 1 commit into from
Closed

Added missing 'version0' to launch file #50

wants to merge 1 commit into from

Conversation

phvass
Copy link

@phvass phvass commented Sep 10, 2014

Potential bug in other launch files as well.

thiagodefreitas
thiagodefreitas reviewed Sep 11, 2014
View reviewed changes
motoman_driver/launch/robot_interface_streaming_fs100.launch
<arg name="version0" value="$(arg version0)" />

<!--arg name="version_0.x" value="$(arg version0)" /-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phvass I do not see the need for this change.

@shaun-edwards
Copy link
Member

@phvass, thanks for the effort, but this has been addressed in a more user friendly way by #89.

Closing this as #89 removes the need for version0 at a launch level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phvass @shaun-edwards @thiagodefreitas