-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MH5: Add Short & Long Variants (based on pull request #380) #518
Open
cjue
wants to merge
9
commits into
ros-industrial:kinetic-devel
Choose a base branch
from
isys-vision:kinetic-devel-update-mh5
base: kinetic-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update MH5: Add Short & Long Variants (based on pull request #380) #518
cjue
wants to merge
9
commits into
ros-industrial:kinetic-devel
from
isys-vision:kinetic-devel-update-mh5
Commits on Mar 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8c21a54 - Browse repository at this point
Copy the full SHA 8c21a54View commit details -
Increase Collision Mesh Fidelity
Meshes were simplified using "Quadric Edge Collapse Decimation" method to improve collision planning between L and R links. Attention was made to retain a similar number of faces & verticies as the convex hull had for comparable performance. Previous collision meshes were created using the "Convex Hull" method.
Configuration menu - View commit details
-
Copy full SHA for 22ae043 - Browse repository at this point
Copy the full SHA 22ae043View commit details -
Reduced MH5L "L" and "R" link mesh file sizes from ~2MB to suggested < 1 MB. Mesh files were reduced using "Quadric Edge Collapse Decimation" method with priority to maintaining boundary location and quality of polygons.
Configuration menu - View commit details
-
Copy full SHA for 8b799c2 - Browse repository at this point
Copy the full SHA 8b799c2View commit details -
Link meshes for the MH5L matching those of the MH5 were removed. Effected URDF references redirected to MH5 meshes. Moved unique "link-s" mesh to dedicated mh5_old_variants directory. Updated changelog to reflect shared meshes.
Configuration menu - View commit details
-
Copy full SHA for 9745387 - Browse repository at this point
Copy the full SHA 9745387View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29b3149 - Browse repository at this point
Copy the full SHA 29b3149View commit details -
Configuration menu - View commit details
-
Copy full SHA for eead220 - Browse repository at this point
Copy the full SHA eead220View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1128e67 - Browse repository at this point
Copy the full SHA 1128e67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 625eb57 - Browse repository at this point
Copy the full SHA 625eb57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17c7d81 - Browse repository at this point
Copy the full SHA 17c7d81View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.