Add BSD 3-Clause license for macro extract_package_metadata #25
Conversation
|
More discussion here. |
| BSD 3-Clause License | ||
|
|
||
| Copyright (c) 2020, ABB Schweiz AG | ||
| Copyright (c) 2020, Southwest Research Institute |
There was a problem hiding this comment.
I'm not sure you should add this. SwRI hasn't added anything.
perhaps the entire "copyright" line shouldn't be here, as you're providing the license text itself, without attaching it to anything specific here.
The attribution would then be close to the snippet you copied.
There was a problem hiding this comment.
I'm not sure you should add this. SwRI hasn't added anything.
A few of the function are ones that I had added like configure_package, and those related discover gtest. Just noticed that SwRI copyright was not present.
There was a problem hiding this comment.
perhaps the entire "copyright" line shouldn't be here, as you're providing the license text itself, without attaching it to anything specific here.
Is this still relevant breaking out the code into a separate file?
There was a problem hiding this comment.
I had understood you only added the BSD license file for the snippet we're discussing in ros-industrial/abb_robot_driver#8. If there is more BSD covered code, then of course you should do whatever it necessary.
| # This extracts package name and version to the following variables | ||
| # ${prefix}_extracted_name and ${prefix}_extracted_version | ||
| # This was taken from https://github.com/ros-industrial/abb_robot_driver, author Jon Tjerngren | ||
| # This was taken from https://github.com/ros-industrial/abb_robot_driver | ||
| # Author: Jon Tjerngren | ||
| # Copyright (c) 2020, ABB Schweiz AG | ||
| # License: BSD 3-Clause |
There was a problem hiding this comment.
I've seen projects separate out code under different licenses by storing things in separate files.
That would also make it easy to attach the appropriate license: you could just include the license header in the file which falls under that license.
You could then of course still include(..) that file in this one.
There was a problem hiding this comment.
That works. Should I remove all LICENSE files from the repository?
There was a problem hiding this comment.
No, I don't believe so.
I've just seen it done the way I described to avoid mixing different licenses in the same file.
There was a problem hiding this comment.
Looks OK to me, but:
- I'm only one of the authors of that snippet (@jontje is the other)
- IANAL
|
@jontje If you see any issue please let me know. I will merge for now. |
I don't see any issues. |
@gavanderhoorn Is this the correct way to do this?