Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace underscores with dashes in component names for CPack #99

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

marip8
Copy link
Member

@marip8 marip8 commented Jan 10, 2025

Currently, the cpack_component macro does not replace underscores in component names with dashes, as it does with the project name. So, for example the component trajopt_ifopt in the project tesseract_motion_planners gets resolved to tesseract-motion-planners-trajopt_ifopt instead of tesseract-motion-planners-trajopt-ifopt. This PR makes the required change to fix this issue.

Addresses this comment

@Levi-Armstrong Levi-Armstrong merged commit 62ce049 into master Jan 10, 2025
@Levi-Armstrong Levi-Armstrong deleted the fix/cpack-component-names branch January 10, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants