Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focal to list of distros #72

Closed
wants to merge 1 commit into from
Closed

Add focal to list of distros #72

wants to merge 1 commit into from

Conversation

sloretz
Copy link

@sloretz sloretz commented Jan 3, 2020

Mimicking #51

I'm not 100% sure this is still relevant since it sounds like this is a prerequisite to create a focal bootstrap repo #51 (comment), but one already exists.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new bootstrap repository is based on the aptly toolchain and is not using reprepro-updater.
@nuclearsandwich would know better but I think that this branch 'master' is now deprecated fully where the bootstrap repo was the last element using it not the refactor branch.

@sloretz
Copy link
Author

sloretz commented Apr 23, 2020

The new bootstrap repository is based on the aptly toolchain and is not using reprepro-updater.
@nuclearsandwich would know better but I think that this branch 'master' is now deprecated fully where the bootstrap repo was the last element using it not the refactor branch.

@tfoote @nuclearsandwich Sounds like I can assume this repo is deprecated and the PR is not needed then. Closing.

@sloretz sloretz closed this Apr 23, 2020
@nuclearsandwich
Copy link
Contributor

I wanted to check the math on the conclusion here.

This repository contains scripts wrapping reprepro which are still in use on the buildfarm_deployment repository host. The "refactor" branch is in use. (buildfarm_deployment source).

The overall reprepro updater configuration which governs what repositories to set up and signing keys and whatnot is taken from the buildfarm_deployment_config (public example config entry)

ros_buildfarm has an import_upstream job. The default configuration uses the ros_bootstrap.yml also from the buildfarm_deployment_config. (public example config entry)

The config files in this repository for importing from various upstreams are technically usable from the import_upstream job but doing so is quite opaque, especially to people setting up buildfarm replicas. I think at this point we've settled on importing everything into the aptly-backed bootstrap repository and using the import_upstream job to get whatever's in that to the ROS and ROS 2 repositories.

@tfoote
Copy link
Member

tfoote commented May 14, 2020

My conclusion was that master was deprecated. We're still using refactor branch. Though we could consider moving the wrapper scripts into the buildfarm now as that's the only think we're using these days and we've already got lots of wrapper scripts in ros_buildfarm there's not a real need for them to be in a separate repository.

As we're switching to the new repository management tool we should find a way to document and track those packages natively in their old home instead of trying to maintain these rules that we can't/won't ever execute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants