Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use agent_on_jenkins label for jobs which should run on that node. #936

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nuclearsandwich
Copy link
Contributor

The agent_on_master was renamed to agent_on_jenkins in the migration to
cookbook-ros-buildfarm and Ubuntu 20.04. To maintain compatibility the
cookbook still applies the label agent_on_master to the agent_on_jenkins
but since Jenkins upstream is updating the name of the built-in agent
this seems like a good time to update the labels in ROS build farm.

A future release of ROS Buildfarm can remove the old names and simplify
the label expressions again.

Other compound label expressions in this repository and in configuration
files use spaces between the operators and
strings.
The agent_on_master was renamed to agent_on_jenkins in the migration to
cookbook-ros-buildfarm and Ubuntu 20.04. To maintain compatibility the
cookbook still applies the label agent_on_master to the agent_on_jenkins
but since Jenkins upstream is updating the name of the built-in agent
this seems like a good time to update the labels in ROS build farm.

A future release of ROS Buildfarm can remove the old names and simplify
the label expressions again.
@nuclearsandwich nuclearsandwich self-assigned this Jan 27, 2022
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to help us move forward on the rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants