Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completely disable Melodic jobs. #223

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Completely disable Melodic jobs. #223

merged 1 commit into from
Jul 5, 2023

Conversation

clalancette
Copy link

No description provided.

@clalancette
Completely disable Melodic jobs.
d3f21af 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette mentioned this pull request Jun 27, 2023
Merged
6 tasks
nuclearsandwich
nuclearsandwich approved these changes Jul 5, 2023
View reviewed changes
Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly prefer the tag, then delete workflow that we've been using in ros2/ros_buildfarm_config but that apparatus is not yet set up here (no tags are present) so I don't think it makes sense to deviate from this practice for ROS 1 distros.

@clalancette
Copy link
Author

I strongly prefer the tag, then delete workflow that we've been using in ros2/ros_buildfarm_config but that apparatus is not yet set up here (no tags are present) so I don't think it makes sense to deviate from this practice for ROS 1 distros.

Yeah, agreed that I prefer that practice. But I also agree that we can leave this in place for ROS 1.

Thanks for the review, going ahead and merging this one.

@clalancette clalancette merged commit 73175ac into production Jul 5, 2023
@clalancette clalancette deleted the clalancette/disable-melodic branch July 5, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @nuclearsandwich