Return None if pkg-config gives a non-zero exit code #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the ugly stack trace that comes with missing dependencies and makes the build log harder to read. Note that a failure to execute pkg-config at all raises an OSError exception, which is not caught as it indicates an actual bug or severe misconfiguration. This is part of a proposed fix for ros-infrastructure#34
dirk-thomas
added a commit
that referenced
this pull request
Feb 22, 2013
Return None if pkg-config gives a non-zero exit code
dirk-thomas
added a commit
that referenced
this pull request
Mar 11, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the ugly stack trace that comes with
missing dependencies and makes the build log harder
to read.
Note that a failure to execute pkg-config at all
raises an OSError exception, which is not caught as it
indicates an actual bug or severe misconfiguration.
This is part of a proposed fix for #34