Call apt-cache show once with list of packages #557
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve #554.
Instead of checking for virtual packages individually, now the entire list of packages to check are passed to
apt-cache show
. In my tests involving 58 uninstalled packages, this change (in combination with #556) has resulted in a speed up of 3 minutes.It is important to note that I have not had the opportunity to explicitly test with actual virtual packages (ie. the for-loop at L144 never executes since
virtual_packages
has been empty in my test cases).