Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shebang to python3 #706

Closed
wants to merge 1 commit into from
Closed

Conversation

ruffsl
Copy link
Contributor

@ruffsl ruffsl commented Sep 19, 2019

It seems the debian install is broken without this, e.g:

$ rosdep
Traceback (most recent call last):
  File "/usr/bin/rosdep", line 3, in <module>
    from rosdep2.main import rosdep_main
ImportError: No module named rosdep2.main

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that rewriting the shebang is done during the python3 deb release in a programmatic fashion and that changing it here would have unintended affects for those installing this script via other methods.

@ruffsl
Copy link
Contributor Author

ruffsl commented Sep 19, 2019

Ok, never mind this PR then.

@ruffsl ruffsl closed this Sep 19, 2019
@nuclearsandwich
Copy link
Contributor

I've not substantiated the theory but my hypothesis is that the incorrect line endings present when creating the 0.16.0 release interfered with the shebang modification during release. 0.16.1 which was generated from a fixed repository clone appears to work on the bootstrap repository and is moving out to the main repositories now.

@ruffsl ruffsl deleted the patch-2 branch September 19, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants