Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add photo capture feature #46

Closed
wants to merge 1 commit into from

Conversation

kochigami
Copy link
Contributor

Following [WIP] add subscribers/speech.cpp #43, I added to photo capture feature. I checked this with Pepper who has NAOqi 2.3 version, PC which has ROS indigo. It requires prevent calling ros::init without name; use node_name command option instead of namespace #44 and [pepper_bringup/launch/pepper_full.launch] use node_name argument instead of namespace # 11.

If there is any problem, please let me know.

@Karsten1987
Copy link
Contributor

I am not sure if this PR really fits into the core scheduler of naoqi_driver. Wouldn't this better fit in any kind of naoqi_apps folder and can be started separately?

Because this means that every robot depends on the Photofeature app and is not necessarily essential for launching a robot.

Other from this, can you maybe add a parameter for the hard coded path for storing the image?

@vrabaud
Copy link
Contributor

vrabaud commented Dec 27, 2015

@suryaambrose , we need to have this second process that handles non-sensor services.

@vrabaud
Copy link
Contributor

vrabaud commented Dec 27, 2015

Also, @kochigami , please rebase

@kochigami
Copy link
Contributor Author

Sorry for leaving it for a long time.
I'll make ALPhotoCapture features in naoqi_apps in the future.

@kochigami kochigami closed this Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants