-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The node name must not be empty #35
Comments
Which launch file do you use? |
I'm using pepper_full.launch from this repo |
But the namespace is set by default to "pepper_robot" in this launch file, no? |
Yes, and if i use this command |
This is the output i'm getting when I try to launch pepper_bringup.launch (I use this repo and naoqi_driver compiled from source). |
This problem is related to this issue : |
it is working on my machine, please check your package version by running
|
And I'm using ROS Kinetic EDIT: |
Did you compile it from source or installed with apt-get? In any case, for both source and release, it works on Kinetic with Python version, I've just tested it with 2.5. Please try to launch it like this: roslaunch pepper_bringup pepper_full_py.launch |
I tried both and had the same error (with apt-get method and compiled from source). Thanks, python version works but i was interested in the C++ bridge. |
I just commented on the referenced issue. ros-naoqi/naoqi_driver#73 (comment) I think this is a bug and should be changed. @PacoDu do you mind opening a PR against it? I can't test it on my side due to lack of robots. It should at least warn you correctly that you try to pass an empty name to |
Sorry for the delay I was digging inside roscpp and naoqi_driver before proposing a PR. I temporary fixed the issue on my side by adding a fixed node name in ros::init (as proposed by ros-naoqi/naoqi_driver#81) and I was looking for a way to avoid duplication in topic name (c.f. pepper_robot/pepper_robot/). |
I have the same error with ROS Kinetic. @PacoDu , have you found a way to avoid the duplication in the topic name? |
Yes I can publish my code, i'll upload it has soon has i can. It need some cleaning. |
Thanks @PacoDu ! I will try it right now! |
It is working fine for me! Ubuntu 16.04, ROS Kinetic Merci @PacoDu |
Just fixed some remaining line in naoqi_driver (setPrefix) before prefix value verification that I missed in the merge. |
Should we close the issue then? |
Ok for me, It would be useful to merge the pull request. Is the fix working also under Ubuntu 14.04 and ROS Indigo? If needed I could test it. |
the fix should not be needed on indigo given that raising on empty node name has been introduced in Kinetic and not backported to Jade or Indigo. (c.f. ros/ros_comm#894 (comment) and ros/ros_comm#895 (comment)). It would be good to confirm that it doesn't break anything though. |
I didn't have the time to test the fix on ROS Indigo, it would be great if you can confirm that it works @jokla Thanks ! |
Tested under Ubuntu 14.04 and Indigo using the pull request #40 in pepper_robot , it's working! |
This is still not merged? I had the same issue, but the fix above worked for me. |
I'm still facing the issue on launching pepper_full.launch, even after applying #40 in pepper_robot. Any help? Using ROS Kinetic, Ubuntu 16.04, compiled pepper_robot and naoqi_driver from source. |
@metalaman please, do "git pull" in "pepper_robot" and try again. |
Hi, @nlyubova Thanks, I fixed the issue, could you also tell me how to visualize point cloud data, I'm running |
Try to set the "global frame" in RViZ to base_link |
Hi @nlyubova I tried the fix, it isn't working. My pepper_bringup console log shows me the following warning, |
Hi, was finally able to get the point cloud. Thanks a lot for help. |
To make it faster, use /compressed image topic for rgb The difference in quality is not visible, and the speed is much faster. |
And turn off the bottom camera in boot_config if you are not using it. |
In share/boot_config.json And you can take smaller resolution to make it faster |
I'll try those, Thanks again. |
Hi, i'm using Pepper Naoqi OS 2.5.5. Trying to use roslaunch pepper_bringup fail with this error :
what(): The node name must not be empty
After some digging I've identified that this is due to the namespace from pepper_full.launch
<include file="$(find naoqi_driver)/launch/naoqi_driver.launch" ns="$(arg namespace)" >
Removing
ns="$(arg namespace)"
fix the error but naoqi_driver is not starting under /pepper_robot/ namespace.Looking at naoqi_driver src, the error comes from this line:
boost::shared_ptr<naoqi::Driver> bs = boost::make_shared<naoqi::Driver>(app.session(), vm["namespace"].as<std::string>());
and is raised whenbs->setMasterURINet( "http://"+roscore_ip+":11311", network_interface);
is called.vm["namespace"].as<std::string>()
is empty. I'm new to ROS but for what i've understand, starting the module in a namespace create some conflict if the node doesn't have a prefix, if there is no namespace everything work normally and the node start properly.Note that this seems to affect the camera module essentially (no data in rviz for example, even if I bind the camera data to
/naoqi_driver_node/camera/front/image_raw/
).The text was updated successfully, but these errors were encountered: