Action result timeout #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
SteveMacenski
requested changes
Sep 7, 2023
migration/Iron.rst
Outdated
| @@ -77,3 +77,11 @@ New node in nav2_collision_monitor: Collision Detector | |||
|
|
|||
| In this `PR #3693 <https://github.com/ros-planning/navigation2/pull/3500>`_ A new node was introduced in the nav2_collision_monitor: Collision Detector. | |||
| It works similarly to the Collision Monitor, but does not affect the robot's velocity. It will only inform that data from the configured sources has been detected within the configured polygons via message to the ``collision_detector_state`` topic that might be used by any external module (e.g. switching LED or sound alarm in case of collision). | |||
|
|
|||
| Expose action server's result timeout | |||
| ****************************************************** | |||
There was a problem hiding this comment.
The ** need to match length for it to render properly
| Description | ||
| The timeout value (in seconds) for action servers to discard a goal handle if a result has not been produced. This used to default to | ||
| 15 minutes in rclc but was changed to 10 seconds in this `PR #1012 <https://github.com/ros2/rcl/pull/1012>`_, which may be less than | ||
| some actions in Nav2 take to run. |
There was a problem hiding this comment.
For all I'd add:
"For most applications, this should not need to be adjusted as long as the actions within the server do not exceed this deadline. This issue has been raised with OSRF to find another solution to avoid active goal timeouts for bookkeeping, so this is a semi-temporary workaround."
…tion-result-timeout
…ros.org into action-result-timeout
SteveMacenski
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs updates for ros-navigation/navigation2#3787