Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing params for loopback_sim #600

Merged

Conversation

adivardi
Copy link
Contributor

No description provided.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, happy to merge

configuration/packages/configuring-loopback-sim.rst Outdated Show resolved Hide resolved
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
@adivardi adivardi force-pushed the av/loopback_sim_params branch from 33ff01b to ce23d14 Compare October 28, 2024 09:32
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, we had ROSCon, ROS-I, and then I took a short vacation while in Europe. I'm getting back to work this morning :-)

@SteveMacenski SteveMacenski merged commit 3d0b460 into ros-navigation:master Nov 4, 2024
4 checks passed
robbiefish pushed a commit to robbiefish/docs.nav2.org that referenced this pull request Nov 14, 2024
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Signed-off-by: Rob Fisher <rob.fisher@hbkworld.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants