Feat/add gps launch #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
7 tasks
SteveMacenski
requested changes
Sep 24, 2024
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Stevedan Ogochukwu Omodolor <61468301+stevedanomodolor@users.noreply.github.com>
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
|
The test failed which is odd, can you update this v1 to v4? https://github.com/ros-navigation/nav2_minimal_turtlebot_simulation/blob/main/.github/workflows/test.yml#L30 it looks like github actions depreciated something on us. I could fix it in mainline, but you'd still have to rebase |
SteveMacenski
approved these changes
Sep 24, 2024
Signed-off-by: stevedan <stevedan.o.omodolor@gmail.com>
I already did it on my branch, this way when I merge it goes to the main branch and i don't have to rebase. |
SteveMacenski
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes GPS simulation launch