[jazzy] image_publisher: add field of view parameter (backport #985) #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Currently, the default value for focal length when no camera info is provided defaults to `1.0` rendering whole approximate intrinsics and projection matrices useless. Based on [this article](https://learnopencv.com/approximate-focal-length-for-webcams-and-cell-phone-cameras/), I propose a better approximation of the focal length based on the field of view of the camera. For most of the use cases, users will either know the field of view of the camera the used, or they already calibrated it ahead of time. If there is some documentation to fill. please let me know. This PR should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. --------- Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 78d80f7)
mikeferguson
approved these changes
Jun 10, 2024
mikeferguson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the default value for focal length when no camera info is provided defaults to
1.0rendering whole approximate intrinsics and projection matrices useless. Based on this article, I propose a better approximation of the focal length based on the field of view of the camera.For most of the use cases, users will either know the field of view of the camera the used, or they already calibrated it ahead of time.
If there is some documentation to fill. please let me know.
This PR should be straightforward to port it to
Humble,IronandJazzy.This is an automatic backport of pull request #985 done by [Mergify](https://mergify.com).