Some cleanup in package.xml and CMakeLists.txt #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- builds broke sporadically (I think because of the missing *_gencpp in add_dependencies) with missing Packet.h file. - I’m no catkin expert, but these changes make catkin_lint happy (no more errors at least).
|
bump. This breaks source builds... |
|
@tfoote are you watching this repo? |
8 tasks
|
|
||
| <export> | ||
| <rviz plugin="${prefix}/plugin_description.xml"/> |
There was a problem hiding this comment.
Was this just vestigial or something?
There was a problem hiding this comment.
Must have been copy and paste bug, I don't see any history of a plugin_description.xml file.
There was a problem hiding this comment.
yes that is what I assumed
|
I'm going to merge this, @tfoote please speak up here if you disagree and we can revert it. |
wjwwood
added a commit
that referenced
this pull request
Jul 19, 2014
Some cleanup in package.xml and CMakeLists.txt
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_dependencies) with missing Packet.h file.
more errors at least).