Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CMake version to avoid CMP0048 #56

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 11, 2020

This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

Since this is newer than the required version for ROS Indigo, this should probably be retargeted at a new kinetic-devel or noetic-devel branch before being merged.

ros/catkin#1052

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@jonbinney jonbinney changed the base branch from indigo-devel to kinetic-devel March 11, 2020 22:08
@jonbinney jonbinney merged commit 218cc2c into ros-perception:kinetic-devel Mar 11, 2020
@jonbinney
Copy link
Contributor

@sloretz I decided to merge this into a kinetic-devel branch so that kinetic, melodic, and noetic can all share fixes without cherry picking. I'll update the release branch for kinetic and melodic: #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants