Fixed linters in point cloud codec branch

[ahcorde]

No description provided.

[john-maidbot]

When I run the colcon test command, it is just showing me the divergences in the code style.

But is there some command you are running to actually auto format and fix those divergences based on some style guide? I'd like to be able to do this on my end too so you arent having to PR changes like this. I tried ament_clang_format reformat but that does not seem to make colcon test happy 😅 (I will try this again on rolling tonight. maybe its a clang version issue)

[ahcorde]

@john-maidbot

the only one that I now that it's doing this automatically is ament_uncrustify. You can run

ament_uncrustify --reformat <paths>

The others one I'm fixing them one by one

[john-maidbot]

Ah interesting, it looks like there is a conflict of some kind between ament_uncrustify and ament_clang_format (ament/ament_lint/issues/425 ament/ament_lint/issues/158)

It would be nice if this were "auto"-mated rather than having to fix things manually. but i mostly just care about consistency. so for now we can lint by:

• running ament_uncrustify --reformat <paths> to maybe give us a head-start
• running colcon test ....
• fixing lingering failures by hand until colcon test .... is happy

[ahcorde]

I think we can close this one #3 (comment)