-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to tf2 for Jade #322
Conversation
2d51fad
to
7238622
Compare
I haven't been following super closely -- are all the required PRs for TF2 now merged and released? |
just rebased again, and it's all good with tf2 from shadow fixed. |
ce7fadc
to
d9f2bcd
Compare
@DLu , any comment on that ? I know it only compiles with tf2 master (a new release should happen soonish) but if you have any prior comment, please let me know (I rebase this MR once in a while). |
@vrabaud thanks for rebasing (again) -- I'll try to test this out on a robot ASAP |
And then I realized that running this on a robot is a whole bunch of fun, since this is jade.... |
ok, the required changed in tf2 are now in shadow-fixed, feel free to merge whenever. |
and yet another rebase that is safe to merge for buildfarm compilation. |
and guess who rebased for the new year ? :) |
This is to get test_rosie_multilaser.xml to work
Closing in favor of #458 |
Same as #317 but for Jade.
Honestly, this merge request is only useful because it can free you from PCL later. So you might as well drop the indigo version (you won't gain performance or anything else).