Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tf2 for Jade #322

Closed
wants to merge 2 commits into from
Closed

Conversation

vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Mar 26, 2015

Same as #317 but for Jade.
Honestly, this merge request is only useful because it can free you from PCL later. So you might as well drop the indigo version (you won't gain performance or anything else).

@vrabaud vrabaud mentioned this pull request May 9, 2015
@vrabaud vrabaud force-pushed the jade-devel branch 2 times, most recently from 2d51fad to 7238622 Compare May 9, 2015 08:59
@mikeferguson
Copy link
Contributor

I haven't been following super closely -- are all the required PRs for TF2 now merged and released?

@vrabaud
Copy link
Contributor Author

vrabaud commented May 12, 2015

just rebased again, and it's all good with tf2 from shadow fixed.

@vrabaud vrabaud force-pushed the jade-devel branch 3 times, most recently from ce7fadc to d9f2bcd Compare June 14, 2015 19:34
@vrabaud
Copy link
Contributor Author

vrabaud commented Jul 15, 2015

@DLu , any comment on that ? I know it only compiles with tf2 master (a new release should happen soonish) but if you have any prior comment, please let me know (I rebase this MR once in a while).

@mikeferguson
Copy link
Contributor

@vrabaud thanks for rebasing (again) -- I'll try to test this out on a robot ASAP

@mikeferguson
Copy link
Contributor

And then I realized that running this on a robot is a whole bunch of fun, since this is jade....

@vrabaud
Copy link
Contributor Author

vrabaud commented Aug 11, 2015

ok, the required changed in tf2 are now in shadow-fixed, feel free to merge whenever.
Please remember that this is the first step to remove the PCL dependency.

@vrabaud
Copy link
Contributor Author

vrabaud commented Sep 6, 2015

and yet another rebase that is safe to merge for buildfarm compilation.

@vrabaud
Copy link
Contributor Author

vrabaud commented Jan 1, 2016

and guess who rebased for the new year ? :)

vrabaud added 2 commits April 23, 2016 17:33
This is to get test_rosie_multilaser.xml to work
@vrabaud
Copy link
Contributor Author

vrabaud commented May 7, 2016

Closing in favor of #458

@vrabaud vrabaud closed this May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants