Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[forward port] Image publishers use SensorDataQoSProfile (#1031) #1052

Merged
merged 2 commits into from
Jun 17, 2020
Merged

[forward port] Image publishers use SensorDataQoSProfile (#1031) #1052

merged 2 commits into from
Jun 17, 2020

Conversation

jacobperron
Copy link
Collaborator

This is a forward port of #1031 from Eloquent.

@chapulina chapulina added the ros2 label Mar 3, 2020
@chapulina
Copy link
Contributor

Mind triggering CI as described in the wiki?

@jacobperron
Copy link
Collaborator Author

Linux: Build Status

@jacobperron
Copy link
Collaborator Author

jacobperron commented Mar 4, 2020 •
edited
Loading

For comparison, I've triggered jobs for ros2 and eloquent branches:

  • ros2 Build Status
  • eloquent Build Status

@chapulina
Copy link
Contributor

Oh gosh, has uncrustify been updated? All these tests have been passing fine.

The [Err] [Master.cc:96] EXCEPTION: Unable to start server[bind: Address already in use]. There is probably another Gazebo process running. errors are concerning. This means some test is starting Gazebo but not being able to kill it.

@jacobperron
Copy link
Collaborator Author

jacobperron commented Mar 5, 2020 •
edited
Loading

Oh gosh, has uncrustify been updated? All these tests have been passing fine.

I believe the uncrustify errors are due to ament/ament_lint#210, which changed the default config file used for ROS 2.

Edit: The eloquent build I triggered is incorrect since it is using the latest ROS 2 branches. I'll retrigger it.

@jacobperron
Copy link
Collaborator Author

PR fixing uncrustify errors: #1060

@jacobperron
Copy link
Collaborator Author

I've rebased to resolve conflicts.

Linux: Build Status

@chapulina
Copy link
Contributor

This needs rebasing again

@jacobperron
Copy link
Collaborator Author

Rebased.
Linux: Build Status

@chapulina
Copy link
Contributor

uh oh error: ‘SensorDataQos’ is not a member of ‘rclcpp’

@jacobperron
Copy link
Collaborator Author

uh oh error: ‘SensorDataQos’ is not a member of ‘rclcpp’

Fixed in 9791ebc 🙃

@jacobperron
Copy link
Collaborator Author

jacobperron commented Jun 12, 2020 •
edited
Loading

Linux: Build Status

@jacobperron
Image publishers use SensorDataQoSProfile (ros-simulation#1031)
e6ddca1 
All other sensor publishers were updated previously to use the same profile (ros-simulation#926).
I'm not sure if the image publishers were overlooked or the image_transport API didn't
support setting the QoS profile at the time.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Fix typo from rebase
ea7a809 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Collaborator Author

Rebased to get the latest fixes on ros2: Build Status

@jacobperron jacobperron requested a review from chapulina June 17, 2020 20:35
@chapulina chapulina merged commit cedd022 into ros-simulation:ros2 Jun 17, 2020
@jacobperron jacobperron deleted the fwd_port_1031 branch June 17, 2020 22:22
@BrettRD BrettRD mentioned this pull request Feb 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @chapulina