[gazebo_plugins] Ensure gazebo_ros_camera Publishes After Reset #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a simulation reset, gazebo_ros_camera does not publish images because it is using its internal (and not reset by the world event) last_update_time_ rather than it's parent sensor's update time. I think all of these issues were fixed in the main gazebo repo in the last major release or two, but it looks like the plugins were not fully updated. There are likely similar issues in the other plugins that should be looked into (by someone who is more familiar with them).
|
I think this is covered in pull request #540 which also fixes the problem for other plugins |
@kennysharma could you please verify if the problem is already fixed after the latest changes in |
|
Follow in pr #683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a simulation reset, gazebo_ros_camera does not publish images because it is using its internal (and not reset by the world event) last_update_time_ rather than it's parent sensor's update time.
I think all of these issues were fixed in the main gazebo repo in the last major release or two, but it looks like the plugins were not fully updated. There are likely similar issues in the other plugins that should be looked into (by someone who is more familiar with them).