Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ros2] Revert sim time test #853

Merged
merged 1 commit into from
Dec 26, 2018
Merged

[ros2] Revert sim time test #853

merged 1 commit into from
Dec 26, 2018

Conversation

chapulina
Copy link
Contributor

This needs ros2/rclcpp#608

@chapulina
Copy link
Contributor Author

chapulina commented Dec 12, 2018 •
edited
Loading

Build including the rclcpp PR: Build Status

@chapulina
Copy link
Contributor Author

Ok, giving up on testing the combination with CI since lots of gazebo_ros_pkgs dependencies are not there, some are ignored.... We'll just build everything locally 😬

@tfoote
Copy link
Member

tfoote commented Dec 12, 2018

Reattempting CI with forked ci scripts for removing blacklisted msgs packages and still rclcpp PR: Build Status

@chapulina chapulina added the ros2 label Dec 12, 2018
@chapulina
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@chapulina
Copy link
Contributor Author

FYI @tfoote, the sim time test is passing with this branch now 😉

@j-rivero j-rivero self-requested a review December 26, 2018 19:19
@chapulina chapulina merged commit 64fa38e into ros2 Dec 26, 2018
@chapulina chapulina deleted the revert_sim_time_test branch December 26, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
ros2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapulina @tfoote @j-rivero